New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"env" helper does not function as expected #610

Open
leoj3n opened this Issue Nov 24, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@leoj3n
Copy link
Contributor

leoj3n commented Nov 24, 2018

The value of NODE_ENV seems to become undefined after reattachment:

Development:

node_env

Production:

node_env_prod

Therefore the test in the provided example seems as though it would fail client side: https://github.com/donejs/done-ssr/blob/master/docs/env.md

I've also noticed a window-production mapping in steal config to remap the path of a module file on the browser client does not work. However, a duplicate mapping for window-development does work.

Why do both env.NODE_ENV and window-production seem to have issues on the client side?

Aren't we supposed to be able to check env.NODE_ENV client side and use window-production?

If so, could this be a problem with Heroku? Am I misunderstanding this feature or is this a bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment