New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set "latedef" to "nofunc" in the plugin generator #244

Merged
merged 1 commit into from May 19, 2017

Conversation

Projects
None yet
3 participants
@chasenlehara
Member

chasenlehara commented May 15, 2017

This change makes the plugin generator consistent with the generator generator.

JSHint will no longer complain about the function being “used before it was defined” in this example:

work();

function work() {}
Set "latedef" to "nofunc" in the plugin generator
This change makes the plugin generator consistent with the [generator generator](https://github.com/donejs/generator-donejs/blob/801dace37f583f967ca68d1e3109c169ffec3bd2/generator/templates/static/.jshintrc#L10).

JSHint will no longer complain about the function being “used before it was defined” in this example:

```js
work();

function work() {}
```
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls May 15, 2017

Coverage Status

Coverage remained the same at 98.0% when pulling c1e8af6 on plugin-jshint-latedef into 801dace on master.

coveralls commented May 15, 2017

Coverage Status

Coverage remained the same at 98.0% when pulling c1e8af6 on plugin-jshint-latedef into 801dace on master.

@phillipskevin phillipskevin merged commit 19daf3a into master May 19, 2017

5 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 98.0%
Details

@phillipskevin phillipskevin deleted the plugin-jshint-latedef branch May 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment