Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIle and Image upload #14

Closed
wants to merge 2 commits into from
Closed

FIle and Image upload #14

wants to merge 2 commits into from

Conversation

@sakibmoon
Copy link

@sakibmoon sakibmoon commented Nov 20, 2014

File and image upload doesn't work in current version. I found the reason for that is the form name. I have edited it from 'profile-form-edit' to 'your-profile'.

I am working in wordpress 3.9.1 with buddypress version 2.1.1 and version 2.0.4 of this plugin. Just by changing this my file and plugin upload worked flawlessly.

DIsclaimer: This is my first time working with Buddypress and Buddypress-xprofile-custom-fields-type. I submitted change which works for me and me only. I didn't test with previous versions or anything.

sakibmoon added 2 commits Nov 20, 2014
This is required for current version of buddypress.
This is required for file upload to be successful as buddypress changed it from 'profile-form-data' to 'your-profile'
@donmik
Copy link
Owner

@donmik donmik commented Nov 20, 2014

I'm afraid this change only applies in your case, because the id of the form when you use buddypress defaults is "profile-edit-form" so if in your case it's "your-profile", this is probably because the theme you are using have changed this.

donmik added a commit that referenced this pull request Nov 21, 2014
* Image and File upload was not working when editing extended profile inside wordpress admin. Thanks to sakibmoon!
* #14
@donmik
Copy link
Owner

@donmik donmik commented Nov 21, 2014

Ummm, I understand now, you are editing profile using wordpress admin and I was editing using public pages... So this is why I don't see the same form. Well, it's not usual to do this, this is because nobody see this error until today...xD.
Your code should solve the error on wordpress admin but then the public profile form should stop working.
With the new version 2.0.5, it will work always.

Thanks!

@donmik donmik closed this Nov 21, 2014
@sakibmoon
Copy link
Author

@sakibmoon sakibmoon commented Nov 21, 2014

That's spot on. I never tried to upload from the public pages! Thanks for solving the issue so quickly.

donmik pushed a commit that referenced this pull request Feb 2, 2015
* Image and File upload was not working when editing extended profile inside wordpress admin. Thanks to sakibmoon!
* #14

git-svn-id: http://plugins.svn.wordpress.org/buddypress-xprofile-custom-fields-type/trunk@1030095 b8457f37-d9ea-0310-8a92-e5e31aec5664
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.