Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add new field type: decimal number with two digits of precision #20
I've updated the main php file to solve a problem with translations.
Working with the plugin I noticed the text for the field types wasn't being translated (see screenshot below). I've had to call
For now, I've only tested the 'Decimal number' type and due to
$this->name = __( 'Decimal number (HTML5 field)', 'bxcft' );
Thanks for your great work. I'm going to add Decimal Number as a new type of field. The other two Gender and Diet are too specific I think. Gender is a type of field easy to create using the default types of fields from buddypress. Diet is a field that I don't think most users will need.
I'm checking old threads of support forum, so I hope I can release a new version updated with Decimal Number this week. Again thanks for your work.
Yes, I agree with you. My first aim was to pull request changes only for the Decimal Number type, but GitHub also shows my other changes after the first pull request I made. Gender and Diet are useful in my case, but I understand these are very specific and not convenient for the most of users.
Please, take also into account the changes related to translations just in case you consider to add these changes to your code.
Thanks to you for your fantastic plugin.