Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en: Refactored duplicate code in online_chat #714

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parvezmrobin
Copy link

The changes made and their justifications are as follows

Change Justification
meesage → message Typo
# ... → pass Synchronizing .ipynb and .py
def receive_friend_request(self, friend_id):def check_pending_friend_requests(self): In real-world scenario, we do not immediately react to a friend request. Rather, when we have time we check the list of pending friend requests and accept or reject them.
Moving add_user and remove_user functionality to Chat Both PrivateChat and GroupChat share these functionality. Thus, it is only convenient to move them to the parent class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants