Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 implementation #94 #95

Merged
merged 10 commits into from Sep 16, 2019
Merged

Version 2 implementation #94 #95

merged 10 commits into from Sep 16, 2019

Conversation

@hyochan
Copy link
Member

hyochan commented Sep 16, 2019

Honored to re-implement plugin for new generation followed by the discussion in #93 馃帀.

  • Removed deprecated note in the readme.
  • Make the previous tests work in travis.
  • Documentation on readme for breaking features.
  • Abstracts finishTransaction.
    • acknowledgePurchaseAndroid, consumePurchaseAndroid, finishTransactionIOS.

Android

  • Completely remove prepare.
  • Upgrade billingclient to 2.0.3 which is currently recent in Sep 15 2019.
  • Remove [IInAppBillingService] binding since billingClient has its own functionalities.
  • Add [DoobooUtils] and add getBillingResponseData that visualizes erorr codes better.
  • buyProduct no more return asyn result. It rather relies on the purchaseUpdatedListener.
  • Add feature method acknowledgePurchaseAndroid
    • Implement acknowledgePurchaseAndroid.
    • Renamed consumePurchase to consumePurchaseAndroid in dart side.
    • Update test codes.
  • Renamed methods
    • buyProduct to requestPurchase.
    • buySubscription to requestSubscription.

iOS

  • Implment features in new releases.
    • enforce to finishTransaction after purchases.
    • Work with purchaseUpdated and purchaseError listener as in android.
    • Feature set from react-native-iap v3.
    • Should call finish transaction in every purchase request.
    • Add IAPPromotionObserver cocoa touch file
    • Convert dic to json string before invoking purchase-updated
    • Add getPromotedProductIOS and requestPromotedProductIOS methods
    • Implement clearTransaction for ios
    • Include purchasePromoted stream that listens to iap-promoted-product.
- Removed deprecated note in the `readme`.
- Completely remove prepare.
- Upgrade billingclient to 2.0.3 which is currently recent in Sep 15 2019.
- Remove [IInAppBillingService] binding since billingClient has its own functionalities.
- Add [DoobooUtils] and add `getBillingResponseData` that visualizes erorr codes better.
- `buyProduct` no more return asyn result. It rather relies on the `purchaseUpdatedListener`.
- Add feature method `acknowledgePurchaseAndroid` .
- Implment features in new releases.
- enforce to `finishTransaction` after purchases.
- Work with `purchaseUpdated` and `purchaseError` listener as in android.
- Feature set from `react-native-iap v3`.
- Should call finish transaction in every purchase request.
- Add `IAPPromotionObserver` cocoa touch file
- Convert dic to json string before invoking purchase-updated.
- Add `getPromotedProductIOS` and `requestPromotedProductIOS` methods.
- Implement clearTransaction for ios
- Include `purchasePromoted` stream that listens to `iap-promoted-product`.
@hyochan hyochan mentioned this pull request Sep 16, 2019
@hyochan hyochan requested a review from kwmt Sep 16, 2019
@hyochan

This comment has been minimized.

Copy link
Member Author

hyochan commented Sep 16, 2019

@kwmt Hi there~ Coming from #69, I've made some breaking changes to work on this plugin again coming from 2.0.0. I'm suffering from making travis to pass all the tests and I've had no error in my local env. Could you see the current PR and help me with fix test breaking? 馃檹

Platform is always recognized as linux even if I use FakePlatform from platform.

P.S. Fixed on my own. Thanks.

hyochan added 9 commits Sep 16, 2019
- Attempt to fix testing.
- `finishTransaction` abstracts `finishTransactionIOS`, `acknowledgePurchaseAndroid`, and `consumePurchaseAndroid`.
- Renamed `PurchaseErrorItem` to `PurchaseResult`.
@hyochan hyochan merged commit c468b06 into master Sep 16, 2019
2 of 3 checks passed
2 of 3 checks passed
coverage/coveralls Coverage decreased (-2.2%) to 51.807%
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@hyochan hyochan deleted the release/2.0.0 branch Sep 16, 2019
@hyochan hyochan changed the title [WIP] Version 2 implementation #94 Version 2 implementation #94 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.