Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Migration to bare work flow #108

Merged
merged 12 commits into from Feb 19, 2020
Merged

Migration to bare work flow #108

merged 12 commits into from Feb 19, 2020

Conversation

hyochan
Copy link
Member

@hyochan hyochan commented Feb 19, 2020

Description

Due to issue on e3kit that it doesn't support expo environment, we need to migrate to bare work flow with react-native-unimodules.

Below is a reference from virgil security tech support

image

We are currently big fan of virgil security and we'd like to use this in our app. We also have youtube clip for this.

Tests

  • Making sure current tests are all running ok!
  • Added jest fetch mock.
  • Remove unnecessary test code which is testing expo env which we aren't using any longer.
  • Mock AsyncStorage from @react-native-community.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@hyochan hyochan changed the title Migration/unimodules Migration to bare work flow Feb 19, 2020
@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #108 into master will decrease coverage by 0.14%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
- Coverage   87.71%   87.57%   -0.15%     
==========================================
  Files          33       33              
  Lines        1050     1046       -4     
  Branches      115      114       -1     
==========================================
- Hits          921      916       -5     
- Misses         79       80       +1     
  Partials       50       50

@hyochan hyochan self-assigned this Feb 19, 2020
@hyochan hyochan merged commit 0cc40b9 into master Feb 19, 2020
@hyochan hyochan deleted the migration/unimodules branch February 19, 2020 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant