Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Let user know which productId was the error about #1100

Conversation

AmauryLiet
Copy link
Member

Let users know which productId is the error about, on purchaseErrorListener

Always provided for ios. Not provided for android for non product-specific error

…rListener)

Always provided for ios. Not provided for android for non product-specific error
@AmauryLiet
Copy link
Member Author

AmauryLiet commented Sep 8, 2020

Limitation of the feature: I could not find a way to get the sku in case of cancelled event on Android
(https://github.com/dooboolab/react-native-iap/blob/master/android/src/main/java/com/dooboolab/RNIap/RNIapModule.java#L529)

Afraid that this isn't possible natively...

Still, the information is valuable on iOS

Copy link
Member

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! However, could we also pick up which productId was the success about?

@hyochan hyochan merged commit e433408 into dooboolab-community:master Sep 14, 2020
@hyochan hyochan added the 🍗 enhancement New feature or request label Sep 14, 2020
@AmauryLiet AmauryLiet deleted the feat/provide-productId-on-error-listener branch September 14, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants