fix(agda): preserve input method in evil normal mode#8670
Open
kovan wants to merge 1 commit into
Open
Conversation
Evil clears `current-input-method' in normal state, storing the real method in `evil-input-method'. This breaks agda's minibuffer prompts that use `read-string' with INHERIT-INPUT-METHOD, as they inherit nil. Advise `read-from-minibuffer' and `read-string' to restore the input method from `evil-input-method' when in normal state. Fix: doomemacs#5711 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read-from-minibufferandread-stringto restore the input method fromevil-input-methodwhen in evil normal stateevil-input-methodfirst)(modulep! :editor evil)Context
Fixes #5711. Evil clears
current-input-methodin normal state by design, storing the real method inevil-input-method. When agda2-mode callsread-stringwith INHERIT-INPUT-METHOD=t (e.g. for typecheck prompts), it inherits nil instead of the agda input method. Users must switch to insert mode first as a workaround.Based on the workaround posted by @fdeitylink in the issue thread.
Test plan
agda2-load🤖 Generated with Claude Code