Helm split-window-inside-p broken

[azy2]

I want to apply the helm settings as described in this reddit comment: https://www.reddit.com/r/emacs/comments/52lnad/from_helm_to_ivy_a_user_perspective/d7lypeu/

but I am having problems.

Steps to reproduce

1. Open modules/completion/helm/config.el
2. Replace the :init section with:

  :init
  (setq helm-quick-update t
        ;; Speedier without fuzzy matching
        helm-mode-fuzzy-match nil
        helm-buffers-fuzzy-matching nil
        helm-apropos-fuzzy-match nil
        helm-M-x-fuzzy-match nil
        helm-recentf-fuzzy-match nil
        helm-projectile-fuzzy-match nil
        ;; Display extraineous helm UI elements
        helm-display-header-line t
        helm-ff-auto-update-initial-value nil
        helm-find-files-doc-header nil
        ;; Don't override evil-ex's completion
        helm-mode-handle-completion-in-region nil
        helm-candidate-number-limit 50
        ;; Don't wrap item cycling
        helm-move-to-line-cycle-in-source t
        helm-split-window-inside-p t
        helm-echo-input-in-header-line t
        helm-autoresize-max-height 0
        helm-autoresize-min-height 20)

3. Add the following to the config section:

  (defun helm-hide-minibuffer-maybe ()
    "Hide minibuffer in Helm session if we use the header line as input field."
    (when (with-helm-buffer helm-echo-input-in-header-line)
      (let ((ov (make-overlay (point-min) (point-max) nil nil t)))
        (overlay-put ov 'window (selected-window))
        (overlay-put ov 'face
                     (let ((bg-color (face-background 'default nil)))
                       `(:background ,bg-color :foreground ,bg-color)))
        (setq-local cursor-type nil))))
  (add-hook 'helm-minibuffer-set-up-hook 'helm-hide-minibuffer-maybe)
  (helm-autoresize-mode 1)

4. Restart emacs
5. Split the window (SPC w v)
6. Find-file (SPC .)

Observed behavior

Helm opens at the bottom spanning the entire frame.

Expected behavior

Helm opens in the bottom of the current frame. As in this image https://i.imgur.com/g1Oz9JY.png

System information

Click to expand

- OS: gnu/linux (x86_64-pc-linux-gnu)
- Emacs: 25.2.2 (Sep 22, 2017)
- Doom: 2.0.9 (develop https://github.com/hlissner/doom-emacs/commit/d9d4b6afd51439f5789b8af19b41b5fe5a45124d)
- Graphic display: t (daemon: nil)
- System features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11
- Details:
  ```elisp
  modules:   (:feature eval evil file-templates (lookup (+devdocs +docsets)) services snippets spellcheck syntax-checker version-control workspaces :completion helm :ui doom-dashboard doom-modeline doom-quit hl-todo nav-flash evil-goggles vi-tilde-fringe window-select :tools electric-indent eshell gist imenu impatient-mode make neotree password-store pdf rotate-text term tmux upload :lang cc crystal clojure csharp data elixir elm emacs-lisp ess go (haskell (+intero)) hy (java (+meghanada)) javascript julia latex ledger lua markdown ocaml (org (+attach +babel +capture +export +present +publish)) perl php plantuml purescript python rest ruby rust scala sh swift typescript web :config :private)
  packages:  (ac-alchemist ace-link ace-window adaptive-wrap (alchemist :recipe (alchemist :fetcher github :repo hlissner/alchemist.el :files (:defaults *.exs alchemist-server))) all-the-icons anaconda-mode android-mode async auctex auth-password-store auto-compile auto-yasnippet avy (centered-window :recipe (centered-window :fetcher github :repo anler/centered-window-mode)) cider clj-refactor cmake-ide cmake-mode coffee-mode command-log-mode company company-anaconda company-auctex company-dict company-ghc (company-glsl :recipe (company-glsl :fetcher github :repo Kaali/company-glsl)) company-go company-inf-ruby company-irony company-irony-c-headers company-lua company-php company-quickhelp company-racer company-restclient company-shell company-sourcekit company-statistics company-tern company-web crystal-mode csharp-mode cuda-mode demangle-mode devdocs dired-k disaster dockerfile-mode doom-themes dumb-jump editorconfig elixir-mode elm-mode (emacs-snippets :recipe (emacs-snippets :fetcher github :repo hlissner/emacs-snippets :files (*))) emmet-mode ensime eslintd-fix ess ess-R-data-view ess-smart-equals evil evil-anzu evil-args evil-commentary evil-easymotion evil-embrace evil-escape evil-exchange evil-goggles evil-indent-plus evil-ledger evil-magit evil-matchit evil-mc evil-multiedit evil-numbers evil-org evil-snipe evil-surround evil-textobj-anyblock evil-vimish-fold evil-visualstar (exec-path-from-shell :ignore t) expand-region flycheck flycheck-cask flycheck-crystal flycheck-elm flycheck-irony flycheck-ledger flycheck-perl6 flycheck-plantuml flycheck-popup-tip flycheck-pos-tip flycheck-pycheckers flycheck-rust flyspell flyspell-correct flyspell-correct-helm (fring File <none> added to project /home/ben/.emacs.d/ cache. e-helper) gist git-gutter-fringe git-link git-timemachine gitconfig-mode gitignore-mode glsl-mode go-eldoc go-guru go-mode gorepl-mode groovy-mode haml-mode haskell-mode haxor-mode helm helm-ag helm-bibtex helm-c-yasnippet helm-company helm-css-scss helm-dash (helm-describe-modes :recipe (helm-describe-modes :fetcher github :repo emacs-helm/helm-describe-modes)) helm-pass helm-projectile helm-rtags helm-swoop helm-xref helpful highlight-indentation highlight-numbers highlight-quoted hindent hl-todo htmlize hy-mode hydra imenu-anywhere imenu-list impatient-mode inf-crystal inf-ruby intero irony irony-eldoc js2-mode js2-refactor json-mode julia-mode ledger-mode less-css-mode lua-mode macrostep magit makefile-executor markdown-mode markdown-toc meghanada merlin mips-mode modern-cpp-font-lock moonscript multi-term nasm-mode nav-flash neotree nlinum nlinum-hl nlinum-relative nodejs-repl nose ob-crystal ob-go ob-mongo ob-rust ob-sql-mode ob-translate omnisharp opencl-mode (org-bullets :recipe (org-bullets :fetcher github :repo Kaligule/org-bullets)) org-download org-plus-contrib org-tree-slide (osx-clipboard :ignore t) overseer ox-pandoc ox-reveal pass password-store pcre2el pdf-tools perl6-mode persistent-soft persp-mode php-boris (php-extras :recipe (php-extras :fetcher github :repo arnested/php-extras)) php-mode php-refactor-mode phpunit pip-requirements plantuml-mode prodigy projectile psc-ide pug-mode purescript-mode quelpa quickrun racer rainbow-delimiters rainbow-mode rake restclient rjsx-mode (rotate-text :recipe (rotate-text :fetcher github :repo debug-ito/rotate-text.el)) rspec-mode rtags ruby-refactor rust-mode sass-mode sbt-mode scala-mode shackle shader-mode shrink-path skewer-mode slime smart-forward smartparens solaire-mode ssh-deploy stylus-mode swift-mode tern tide toc-org toml-mode tuareg typescript-mode undo-tree use-package vi-tilde-fringe vimrc-mode visual-fill-column web-beautify web-mode wgrep which-key xref-js2 yaml-mode yard-mode yasnippet)
  elc dirs:  n/a
  exec-path: (/usr/lib/erlang/bin /home/ben/.pyenv/plugins/pyenv-virtualenv/shims /home/ben/.pyenv/shims /home/ben/.pyenv/bin/ /home/ben/opt/cross/bin /usr/local/bin /usr/local/sbin /opt/JetBrains/Toolbox/bin /home/ben/bin/ /home/ben/.cargo/bin /home/ben/.local/bin /home/ben/vulkan/VulkanSDK/1.0.65.0/x86_64/bin /home/ben/opt/i686-elf-4.9.1-Linux-x86_64/bin /home/ben/.pyenv/plugins/pyenv-virtualenv/shims /home/ben/.pyenv/shims /usr/sbin /usr/bin /sbin /bin /usr/games /usr/local/games /usr/lib/emacs/25.2/x86_64-linux-gnu)

[azy2]

Disabling the popup plugin solves the problem. I will investigate further.

Edit. It turns out helm doesn't play nicely with popup mode. The fix is as simple as disabling +all. It'd be nice to have a way of excluding it without removing +all though. #435

[azy2]

#437 Fixes this.