:tabs module (centaur tabs) is broken when upgraded to emacs-devel branch

[kskarthik]

What did you expect to happen?

Switched to emacs-devel branch build from stable.

$ emacs --version
GNU Emacs 29.0.50

What actually happened?

I have recenly switched to emacs-devel build & after that, centuar-tabs seem to have issues working, I got this error in *Messages* buffer

Error during redisplay: (eval (centaur-tabs-line)) signaled (wrong-type-argument stringp (Git "~/my/work/gkapp/")) [55 times]

Describe your attempts to resolve the issue

tried reinstalling tabs module

Steps to reproduce

Open two file buffers & check the *Messages*buffer

System Information

http://paste.debian.net/1237569/

[sorawee]

This happens to me too, after upgrading to Emacs 28.1.

[sorawee]

See also: ema2159/centaur-tabs#181

I confirm that the error is fixed after adding (centaur-tabs-group-by-projectile-project). Perhaps Doom Emacs should add this by default (at least for now)?

[kskarthik]

@sorawee thank you very much for this!

(centaur-tabs-group-by-projectile-project) worked !

[kskarthik]

See also: ema2159/centaur-tabs#181

I confirm that the error is fixed after adding (centaur-tabs-group-by-projectile-project). Perhaps Doom Emacs should add this by default (at least for now)?

@hlissner any comments on this?

[hlissner]

Something has changed in project.el, so perhaps bumping it recently was premature. Try pinning to an older commit, either:

;;; in $DOOMDIR/packages.el
(package! project :pin "125a1a8d15f998cd495ef6a6b981b1a0e201bd2f") ; Feb 23
;; or
(package! project :pin "5347dfc5f32b0408bf4ff7bbace7b2356cf59a8f") ; Jan 27

Then run doom sync -u and restart Emacs.

centaur-tabs-group-by-projectile-project

The reason why this works is it forces centaur-tabs to use projectile instead of project.el. This might work for now, but the issue will resurface when I replace projectile with project.el in the future. Centaur-tabs will need to update its usage of project.el in preparation for the change (since it'll likely be endemic to Emacs 29).

[sorawee]

This commit introduces the issue, FWIW: emacs-mirror/emacs@86969f9. There is a GitHub comment that explains what's going on.

[lesharris]

Error during redisplay: (eval (centaur-tabs-line)) signaled (wrong-type-argument stringp nil) [113 times]

FWIW, even with adding (centaur-tabs-group-by-projectile-project) I was still getting hundreds of these on every keystroke.

This (now-closed?) upstream issue ( em2159/centaur-tabs/issue/3 ) described it as an interaction between centaur-tabs, doom, and all-the-icons.

I can confirm that adding:

(after! centaur-tabs
    (setq centaur-tabs-set-icons nil
          centaur-tabs-gray-out-icons nil)
    ...)

to my config.el seems to stop the problem after an initial spurt of them (presumably before the after! config executes?). Of course now I have no icons in the tabs 😄