peculiar error: (void-function use-package-hook!)

[fuzunspm]

I confirm that...

• I have searched the issue tracker, documentation, FAQ, Discourse, and Google, in case this issue has already been reported/resolved.

• I have read "How to Debug Issues", and will use it to provide as much information about this issue as possible.

• The issue can be reproduced on the latest available commit of Doom.

• The issue can be reproduced on a stable release of Emacs, such as 27 or 28. (Doom does not support development builds like 29+ or any version ending in .50 or .9x)

Expected behavior

Ability to upgrade doom emacs

Current behavior

Can't update doom emacs, with an error message of peculiar error: (void-function use-package-hook!) I tried to clean install doom emacs but still getting the same error

Steps to reproduce

~/.emacs.d/bin/doom upgrade
> Preparing to upgrade Doom Emacs and its packages...
x There was an unexpected runtime error
  Message: Failed to fetch from upstream

2. cd ~/.emacs.d

$ cd ~/.emacs.d   # or wherever you've cloned Doom to
$ git reset --hard a9866e37e45b43785116ef474c8cd6aa9b5185dd
$ git pull origin master
$ doom sync -u
`peculiar error: (void-function use-package-hook!) `

System Information

https://pastebin.com/RWgvYiDQ

[milanglacier]

I have the same issue after the update.
Indeed I have fork the doom to a specific commit I feel stable and everytime I find the latest doom won't work, I just reinstall from my fork .

[fuzunspm]

@milanglacier same here, I restore it from backup

[charignon]

I tried the last 10 commits and they are all broken because of that issue. I went back to the sha you mentioned in the issue description and I am able to get a working install. Should we have CI to catch those kind of regressions?

[hlissner]

This issue is occurring for three reasons:

1. $DOOMDIR/init.el is now loaded sooner in the startup process (in the context of $EMACSDIR/early-init.el). This is before use-package is loaded.
2. I am slowly phasing out use-package from Doom (it has been moved to a :config use-package module, which is currently hard-coded as an active module until use-package has been fully removed from Doom's internals (after which it'll be opt-in)).
3. The v3 release will introduce a few breaking changes, mostly to resolve its technical debt. I'll document those further on Discourse, once it is released closer to its release date. There will be breaking changes trickling in between now and its eventually release.

To get around this, either move your use-package-hook! calls to $DOOMDIR/config.el (where it is possible), or do the following in $DOOMDIR/init.el:

(setq use-package-inject-hooks t)

Then add your configuration to the use-package hooks directly. To quote use-package-inject-hooks's documentation:

In particular, for a given package foo, the following hooks
become available:

use-package--foo--pre-init-hook
use-package--foo--post-init-hook
use-package--foo--pre-config-hook
use-package--foo--post-config-hook

Should we have CI to catch those kind of regressions?

Already working on it as part of the 3.0 release.