Certain keybinds missing on Emacs 29

[TomFryers]

I confirm that...

• I have searched the issue tracker, documentation, FAQ, Discourse, and Google, in case this issue has already been reported/resolved.

• I have read "How to Debug Issues", and will use it to provide as much information about this issue as possible.

• The issue can be reproduced on the latest available commit of Doom.

• The issue can be reproduced on a stable release of Emacs, such as 27 or 28. (Doom does not support development builds like 29+ or any version ending in .50 or .9x)

Expected behavior

All keybinds are available. For instance,SPC p p should open the list of projects.

Current behavior

Some keybindings are missing (Evil ones?). This is a screenshot of the splash screen after pressing SPC. Two of the menu items have the wrong keybinding, and the menu at the bottom is missing things (e.g. b).

Pressing SPC p p gives SPC p p is undefined.

Adding

(setq use-package-inject-hooks t)

to the start of init.el and

 (defadvice! fixed-doom-module-list (fn &rest args)
    :around #'doom-module-list
    (nreverse (apply fn args)))

to the end makes the problem seem to disappear.

This is similar to #6813.

Steps to reproduce

1. Open Emacs (master, f6fb2b9e1).
2. Observe C-c p p instead of SPC p p on the splash screen.

System Information

https://pastebin.com/tFdL8uJu

[hlissner]

Is your M-x doom/info from before or after you added the fixed-doom-module-list fix to your config?

[agzam]

I have the same problem, except the listed workarounds didn't work.
I have to say these few days were highly disappointing for me. I use Emacs 29 with --native-comp. It takes a while to build it. It seems I can no longer go back to 28 because I'm already utilizing things that don't exist in 28.
I don't even use too many Doom modules, mostly my own. I have built an extensive configuration using Doom's core and macros. I am extremely happy with it. I lost two days of work trying to find a workaround, and I still don't understand the underlying issue. It looks like I have no other option but to roll a few days back. And live without updating Doom until the problem gets fixed.

Rolling back to 5a5195b still didn't fix it. I had to go further back 10eb5db

[TomFryers]

That's without the workaround. With the fixed-doom-module-list fix, it's this, which seems just to have the module list reversed.

[TomFryers]

After re-installing Doom, the workaround no longer works (but neither do the keybindings).

[agzam]

Hey, guys. You know what? After countless attempt to fix it on my machine, I decided to try Yamamoto Mitsuharu's Mac port. Installed it via brew --with-metal and --with-native-comp flags, and the keybindings are working with 95bdc3b of Doom.

I know it's not 29, but I still had problems in 28 installed via emacs-plus formula.
Mac port has other problems (for example it just hangs for no apparent reason) but I'm not experiencing issues with keybindings.

The only thing I had to do is to add this:

(after! general
  (general-auto-unbind-keys))

Otherwise it would complain "Key sequence starts with non-prefix key".

This all so weird. Why wouldn't it work before? Why it works now? Why macport version hangs? The last one I bet has absolutely nothing to do with Doom.

[hlissner]

I have to say these few days were highly disappointing for me. I use Emacs 29 with --native-comp. It takes a while to build it. It seems I can no longer go back to 28 because I'm already utilizing things that don't exist in 28.

@agzam I'm afraid it's something you should get used to, if you intend to live on the bleeding edge of Emacs. I'm sorry if I've said this to you before (on Github, Discourse, or Discord), but this is something all Emacs 29 users should hear at least once, so it bears repeating:

I highly recommend you downgrade to 28.1 or 28.2 (and not 28.2.50, that's a development build) if you don't want to deal with these problems as often as you're going to. Otherwise, find a commit of Emacs 29 that works for you and never upgrade until it gets a stable release next year. Every update will be a toin coss if you don't.

Side note: how many of Doom's modules you use won't matter. Our modules rely little on upstream Emacs and more on third party packages, whose installed versions we can control (through pinning). What Doom cannot control is what version of Emacs you use it on, so Doom's core is most sensitive to changes in Emacs.

That's without the workaround. With the fixed-doom-module-list fix, it's this, which seems just to have the module list reversed.

@TomFryers Your module list looks correct without the fix. As I suspected, the workaround is just masking your issue, not fixing it.

(setq use-package-inject-hooks t)

@TomFryers I have no idea why this should fix your issue. It has nothing to do with Doom. Is your private config up somewhere I can see it?

[hlissner]

@TomFryers Nevermind. I updated to a newer version of 29 and am now able to reproduce the original issue. It appears something has changed on 29, again, in the time I was debugging #6813. I'll look into this further.