org-roam trying to use emacsql built-in sql support for version 29

[ieremies]

I confirm that...

• I have searched the issue tracker, documentation, FAQ, Discourse, and Google, in case this issue has already been reported/resolved.
• I have read "How to Debug Issues", and will use it to provide as much information about this issue as possible.
• The issue can be reproduced on the latest available commit of Doom.
• The issue can be reproduced on a stable release of Emacs, such as 27 or 28. (Doom does not support development builds like 29+ or any version ending in .50 or .9x)

Expected behavior

When I start doom, it should not give me an error regarding not loading sqlite and consequently braking most modes.

Current behavior

When starting doom (or running doom doctor, same error), doom would complain about not finding sqlite

Message: File is missing
    Details: ("Cannot open load file" "No such file or directory" "sqlite")
    Backtrace:
      (require sqlite)
      (load-with-code-conversion "/home/ieremies/.emacs.d/.local/straight/build-28.2/emacsql/emacsql-sqlite-builtin.el" "/home/ieremies/.emacs.d/.local/straight/build-28.2/emacsql...
      (require emacsql-sqlite-builtin nil t)
      (progn (require 'emacsql-sqlite-builtin nil t) (functionp 'emacsql-sqlite-builtin))
      (and (progn (require 'emacsql-sqlite-builtin nil t) (functionp 'emacsql-sqlite-builtin)) (functionp 'sqlite-open))
      (if (and (progn (require 'emacsql-sqlite-builtin nil t) (functionp 'emacsql-sqlite-builtin)) (functionp 'sqlite-open)) 'sqlite-builtin 'sqlite)
      ((closure (t) nil "" (if (and (progn (require 'emacsql-sqlite-builtin nil t) (functionp 'emacsql-sqlite-builtin)) (functionp 'sqlite-open)) 'sqlite-builtin 'sqlite)))
      (funcall (closure (t) nil "" (if (and (progn (require 'emacsql-sqlite-builtin nil t) (functionp 'emacsql-sqlite-builtin)) (functionp 'sqlite-open)) 'sqlite-builtin 'sqlite)))
      (eval (funcall #'(closure (t) nil "" (if (and (progn (require 'emacsql-sqlite-builtin nil t) (functionp 'emacsql-sqlite-builtin)) (functionp 'sqlite-open)) 'sqlite-builtin '...
      (custom-initialize-reset org-roam-database-connector (funcall #'(closure (t) nil "" (if (and (progn (require 'emacsql-sqlite-builtin nil t) (functionp 'emacsql-sqlite-builti...
      (custom-declare-variable org-roam-database-connector (funcall #'(closure (t) nil "" (if (and (progn (require 'emacsql-sqlite-builtin nil t) (functionp 'emacsql-sqlite-builti...
      (load-with-code-conversion "/home/ieremies/.emacs.d/.local/straight/build-28.2/org-roam/org-roam-db.el" "/home/ieremies/.emacs.d/.local/straight/build-28.2/org-roam/org-roam...

Steps to reproduce

1. start doom or run doom doctor

System Information

https://pastebin.com/eJT6fJnw

[ieremies]

So, I updated my doom after a long time (4 months) and, along some other problems, I got this error, saying I was missing sqlite. After some diving, I found that in Dec 25th org-roam added support for sqlite-builtin by checking whether the file emacs-sqlite-builtin was present, which was added in Oct 24th for emacs 29. Since I'm running emacs 28.2, it fails.

Full disclaimer, while trying to fix it, I did find a left over (unpin! roam) from a year ago. I did delete it, reinstalled, and could reproduce it when running with the current doom version (74422df). I was not able to find which version doom have pinned emacsql, but I don't see how I've could have messed that up...

Deleting emacs-sqlite-builtin.el from .emacs.d/.local/straight/build28.2/emacsql/ fixed the problem for now.

[hlissner]

The root of this issue was resolved in 7c1c1f5 (where org-roam is bumped) and 52d413f
(which should prevent stale builds in the future), but (as ieremies said) the package needs to be manually rebuilt at least once after this update to fix this problem:

• The simple but slow way: $ doom build (rebuilds all packages),

• The faster way:

  # assuming Doom was cloned to ~/.config/emacs
  $ rm -rf ~/.config/emacs/.local/straight/{repos,build-*}/emacsql*
  $ doom sync

I'll close this for now, but feel free to follow up here. I'll reopen it if the issue returns.

[hw202207]

The simple way (doom build) didn't work for me but the faster way did.

[NightPyHask]

Error caused by user's config or system: /home/dave/.doom.d/config.el, (error /home/dave/emacs-configs/doom-emacs/.local/straight/build-28.2/emacsql/sqlite/emacsql-sqlite has failed immediately)

About the same problem. Sadly nothing mentioned above helped.

I'm using Arch.

[brucejuz]

Error caused by user's config or system: /home/dave/.doom.d/config.el, (error /home/dave/emacs-configs/doom-emacs/.local/straight/build-28.2/emacsql/sqlite/emacsql-sqlite has failed immediately)

About the same problem. Sadly nothing mentioned above helped.

I'm using Arch.

I have the same problem.

Here is how I fixed it:
Delete (unpin! org-roam) in my package.el.
Then in my init.el, I cancel the "+roam2);
Run doom sync and doom purge to delete the org-roam.
Then turn on "+roam2" in my init.el again. Run doom sync to reinstall the org-roam.
It fixed my problem.

It seemed that the new org-roam are not compatible with emasql. So I think we must pin the org-roam.
Hope it can help you too!