`:editor format` no longer supports onsave lsp formatting

[vincowl]

I confirm that...

• I have searched the issue tracker, documentation, FAQ, Discourse, and Google, in case this issue has already been reported/resolved.
• I have read "How to Debug Issues", and will use it to provide as much information about this issue as possible.
• The issue can be reproduced on the latest available commit of Doom.
• The issue can be reproduced on a stable release of Emacs, such as 27, 28, or 29. (Unstable versions end in .50, .60, or .9x)

Expected behavior

When I save a buffer using a lsp server that has a format capability, doom should launch the lsp-formater through +format/buffer

Current behavior

When I save a buffer using a lsp server that has a format capability, doom launches apheleia--format-after-save directly

Steps to reproduce

1. Be sure to have prettier not installed on your system (used by apheleia)
2. Open Emacs
3. Open a badly formated html file (for instance) with html-ls installed
4. Save the file
5. The file should not be formated

System Information

https://pastebin.com/RZQYHPaD

[vincowl]

while waiting for a built-in solution, a workaround found on the discord server could be something like :

(setq-hook! 'web-mode-hook
  apheleia-inhibit t
  +format-with nil)
(add-hook 'web-mode-hook
          (lambda()
            (add-hook 'before-save-hook #'+format/buffer nil t)))

[fdeitylink]

I am experiencing similar issues. I use ormolu to format my Haskell code, which the language server uses by default. However, since (format +onsave) uses apheleia-global-mode and apheleia defaults to using brittany, format on save uses the incorrect formatter. Instead of

(when (modulep! +onsave)
  (add-hook 'doom-first-file-hook #'apheleia-global-mode))

(written here) it may be better to write

(when (modulep! +onsave)
  (add-hook 'before-save-hook #'+format/buffer))

Happy to make this a PR if these seems like the right way to go. Seemed to work for me, more or less generalizes what @vincowl wrote above.

EDIT: This seems to cause issues where it attempts to format all buffers, even those that lack formatters (or where you wouldn't want to format). I would like to make a general solution but I'm not sure what the best course of action is.

[goncalvesnelson]

I think the solution can be found here: radian-software/apheleia#120
This seems to have worked for me.