Skip to content

Added helm to the popup ignore list #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

azy2
Copy link

@azy2 azy2 commented Feb 26, 2018

Helm manages it's own windows and doesn't interface with popup very well.

@hlissner
Copy link
Member

hlissner commented Mar 3, 2018

I'm afraid I can't accept this into Doom. I consider this as a personal customization and would rather leave this to private modules than make this the default, for a couple reasons:

  1. I've tried to model the helm and ivy modules to act visually similar to CtrlP (vim), Goto-Anywhere (sublime text/atom), and command-T (textmate), as a reasonable default, and leave it to users to undo or change in their customizations. I agree that the whole-frame approach doesn't suit widescreens well, but I'd like to implement child frame support to address this instead.
  2. The completion/helm module's defaults work fine with feature/popup. If this is not the case, that is a bug.
  3. It is easier to put (set! :popup "^\\*helm" :ignore) in a private config than it is for another user to either remove that rule from display-buffer-alist or define a new rule to shadow the old one simply to reinstate the fallback behavior of +all.

@hlissner hlissner closed this Mar 3, 2018
@azy2
Copy link
Author

azy2 commented Mar 3, 2018

That seems reasonable to me. I didn't think it would do anything to the default setup and I figured it would make customizing helm less confusing. It certainly took me awhile to figure out why my helm settings weren't applying. Perhaps there's a fix in popup that's less drastic than :ignore that maintains the original behavior.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants