Jump to conversation
Unresolved conversations (2)
@iyefrat iyefrat Jul 28, 2021
Some of the annotations in the `project-file` type commands where you first select a project and then a file are a bit shaky, due to marginalia not yet providing very good support for these types of project commands. For some commands (e.g. `doom/find-file-in-other-project`) both the project list and file list get file annotations, but for others such as `projectile-switch-project`, they don't really get annotations.
modules/completion/vertico/config.el
@iyefrat iyefrat Jul 27, 2021
Note that there is an interesting alternative to the which-key indicator, the recently introduced verbose indicator (it's what's used by default). it looks like this: ![image](https://user-images.githubusercontent.com/19792685/127222253-402f43e9-884e-49ca-945c-47b435eeeda9.png) this is more useful than `which-key` information-wise, but breaks with doom using which key everywhere else, and this information can also be reached by pressing `C-h` to start a vertico filtering session.
modules/completion/vertico/config.el
oantolin iyefrat
bdarcus
Resolved conversations (4)
@minad minad Jul 29, 2021
I've seen this (4) pattern a few times, which emulates the interactive prefix argument. I recommend to use this only for commands where (4) actually carries some meaning and if not use something else. For `consult-line-multi` this works: ~~~ elisp (consult-line-multi 'all-buffers) ;; for special purposes you can filter the buffer list (consult-line-multi '(:include ".*\\.el\\'" :exclude "init\\.el\\'")) ~~~
Outdated
modules/config/default/+evil-bindings.el
iyefrat
@iyefrat iyefrat Jul 29, 2021
should this be `#'doom-project-root`?
Outdated
modules/completion/vertico/config.el
iyefrat hlissner
@hlissner hlissner Jul 26, 2021
Why is it necessary to call this twice and in this manner?
Outdated
...es/completion/vertico/autoload/vertico.el
elken iyefrat
@hlissner hlissner Jul 26, 2021
Would you mind bumping this again? To include https://github.com/hlissner/emacs-doom-themes/pull/640 and https://github.com/hlissner/emacs-doom-themes/pull/639
Outdated
modules/ui/doom/packages.el
iyefrat