Skip to content

module: add :editor meow #5868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

VitalyAnkh
Copy link
Contributor

Add an editor/meow module, integrate meow into Doom

@VitalyAnkh VitalyAnkh requested a review from hlissner as a code owner December 4, 2021 19:47
@VitalyAnkh VitalyAnkh force-pushed the meow-module branch 2 times, most recently from 17b0f68 to 476fdf1 Compare December 4, 2021 20:11
@hlissner hlissner added is:feature Adds or requests new features, or extends existing ones re:modules Pertains to adding, removing and management of modules labels Dec 4, 2021
@hlissner hlissner added this to the v22.02 milestone Dec 4, 2021
@hlissner hlissner added the was:moved Is, was, or will be addressed elsewhere label Dec 4, 2021
@hlissner
Copy link
Member

hlissner commented Dec 4, 2021

I'm not currently accepting new editing paradigm modules in Doom so I must turn this down, but I will be opening up a repository for community-developed modules in https://github.com/doomemacs/contrib-modules (not public yet) some time in the next few months (and changing how users can manage their module sources from their doom! block). I'll accept this module there, when it is available.

I'll keep this PR open until that happens.

module: add :editor meow
@not-leader
Copy link

if you do add the meow module, please use this one

@bdarcus
Copy link
Contributor

bdarcus commented Dec 18, 2021

if you do add the meow module, please use this one

What's the difference?

In any case, +1 on a meow contrib module.

@iyefrat
Copy link
Member

iyefrat commented Dec 19, 2021

@bdarcus
That repo is a standalone module that can be easily imported to your private doom config (and eventually be moved to contrib-modules). To use this PR you'd have to live on an alternate doom git branch.

@hlissner hlissner changed the title Add editor/meow module module: add :editor meow Jan 12, 2022
@ksqsf
Copy link

ksqsf commented Oct 29, 2022

Hey, any progress on this?

@hlissner hlissner removed the was:moved Is, was, or will be addressed elsewhere label Nov 1, 2022
@hlissner
Copy link
Member

hlissner commented Nov 1, 2022

Hey there! I'm preparing to move modules out of Doom's core to doomemacs/modules (official modules) and doomemacs/contrib-modules (community-maintained/contributed modules), and am resolving/transferring related PRs and issues. As this repo will no longer house modules (and Github offers no way to transfer PRs), I am closing it, but I'm still interested in its contents. Would you mind re-PRing it to https://github.com/doomemacs/contrib-modules?

There'll be an announcement on Discourse (under #news) this weekend about why this is happening and the general state and direction of Doom, if you're curious.

In any case, sorry for the trouble and thank you for the PR and help!

@hlissner hlissner closed this Nov 1, 2022
@hlissner hlissner mentioned this pull request Oct 20, 2024
4 tasks
@jgarte
Copy link

jgarte commented Oct 20, 2024

@VitalyAnkh
Copy link
Contributor Author

For the time being, I recommend this doom module for meow.

@devdumpling
Copy link

devdumpling commented Oct 21, 2024

@VitalyAnkh why that one over doom-meow? I'm just getting into doom emacs and wanted meow, so added doom-meow. However, notice a lot of the binds are missing and that it seems not maintained. Stumbled across this thread and noticed you're an author of doom-meow.

Any reason for the swap? My main issue so far has been trying to figure out exactly which doom emacs commands are unbound when using meow vs evil. I'm used to vanilla emacs binds that I used years ago when learning emacs. I migrated to VS Code for a while and now coming back to emacs via doom emacs. I wanted to try learning meow rather than evil, as it makes more sense to me as an extension of the emacs binds I already have in muscle memory.

@not-leader
Copy link

not-leader commented Oct 22, 2024 via email

@VitalyAnkh
Copy link
Contributor Author

why that one over doom-meow?

The original author of doom-meow (@not-leader) is not using doom any more and not maintainging doom-meow. I'm using my own meow configuration for integration with doom, which is opinionated and not suitable for general community module. https://github.com/45mg/doom-meow-module is clean and modular, and I have requested to include it in meow-edit organization: meow-edit/doom-meow#1. If the author agreed, we will have an active maintainer and a place to improve the module together.

I have seen some PRs to doom-meow but I haven't got enought time (and interest 🫤) to review them. But if the author of https://github.com/45mg/doom-meow-modul doesn't repond in time(maybe one or two weeks), I plan to continue improving doom-meow.

@devdumpling
Copy link

why that one over doom-meow?

The original author of doom-meow (@not-leader) is not using doom any more and not maintainging doom-meow. I'm using my own meow configuration for integration with doom, which is opinionated and not suitable for general community module. https://github.com/45mg/doom-meow-module is clean and modular, and I have requested to include it in meow-edit organization: 45mg/doom-meow-module#1. If the author agreed, we will have an active maintainer and a place to improve the module together.

I have seen some PRs to doom-meow but I haven't got enought time (and interest 🫤) to review them. But if the author of https://github.com/45mg/doom-meow-modul doesn't repond in time(maybe one or two weeks), I plan to continue improving doom-meow.

Thanks for the rundown--exactly the context I was looking for. I'm running with the 45mg doom-meow-module for now and will try to wrap my head around that. Once I have some idea what I'm doing I'd be happy to help a bit.

On a tangent, holy shit thank you so much for writing all of this. This is wildly helpful to me as someone who spent time in Emacs many years ago, moved away, and is now coming back trying to understand the state of Doom from the ground up.

@VitalyAnkh
Copy link
Contributor Author

@devdumpling I must clarify that my emacs configuration is adapted from Teco's great configuration. Teco's config is so awesome that I forked it and added some of my things to it. Kudos to Teco!

@devdumpling
Copy link

Got it. Well, props either way. Learning a lot following these threads.

Have spent the last week purely trying to tweak motion bindings and fix which-key maps (so really living the emacs experience).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:feature Adds or requests new features, or extends existing ones re:modules Pertains to adding, removing and management of modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants