refactor(format): replace with apheleia

[elken]

Replace format-all with apheleia to grealy simplify the formatting setup.

For the most part, this is a low degree of ready the only thing missing is documentation and more granular testing on each module.

I've also had a recent thought on how to handle LSP formatters, previously I ignored them in favour of apheleia but I might forward-port the same logic here for the new module.

[fosskers]

@yufengwang As mentioned in the new documentation for the format module, region formatting is not currently supported by Apheleia.

[ladieman217]

okay, is there any workaround? because i highly depend on format/region on a very old codebase @fosskers

[liaowang11]

okay, is there any workaround? because i highly depend on format/region on a very old codebase @fosskers

With this tweak, it seems to be working for me. Note, the set-buffer-modified-p maybe irrelevant.

@@ -8,7 +8,7 @@
 
 (defun +format-region (start end &optional callback)
   "Format from START to END with `apheleia'."
-  (when-let* ((command (apheleia--get-formatter-command
+  (when-let* ((command (apheleia--get-formatters
                         (if current-prefix-arg
                             'prompt
                           'interactive)))
@@ -23,7 +23,7 @@
       ;; Ensure this temp buffer seems as much like the origin buffer as
       ;; possible, in case the formatter is an elisp function, like `gofmt'.
       (cl-loop for (var . val)
-               in (cl-remove-if-not #'listp (buffer-local-variables origin-buffer))
+               in (cl-remove-if-not #'listp (buffer-local-variables cur-buffer))
                ;; Making enable-multibyte-characters buffer-local causes an
                ;; error.
                unless (eq var 'enable-multibyte-characters)
@@ -45,7 +45,9 @@
              ;; restore indentation without affecting new
              ;; indentation
              (indent-rigidly (point-min) (point-max)
-                             (max 0 (- indent (+format--current-indentation))))))
+                             (max 0 (- indent (+format--current-indentation)))))
+           (set-buffer-modified-p nil)
+           )
          (with-current-buffer cur-buffer
            (delete-region start end)
            (insert-buffer-substring-no-properties formatted-buffer)

[elken]

In future, please use issues when reporting issues.

As for this change, I've tested it locally and it seems to "kind of" work but since as pointed out it's not supported upstream, if you're happy with this fix I'll PR it in.

[offbyone]

@elken thank you for the work on this; it's working well for me, and I'm glad to have it in main.

[ladieman217]

@elken thanks for your hard work

[johalun]

@yufengwang

Hey! Please tell me how you got region formatting working. If I don't modify any settings SPC c f formats incorrectly (not using my .clang-format).

If I add (setq +format-with-lsp nil) I get the error Symbol’s function definition is void: apheleia--get-formatter-command for region formatting but full buffer formatting works.

I'm on latest master and the doom code does contain the changes above.

[elken]

a) if you're having issues, report them through the proper channels
b) if you were using the latest master, you'd have #7427 which resolves that error so please update to the latest master

[ladieman217]

@johalun I have submit a new issue, it still has bugs, #7438

[lroolle]

@elken You may have removed the +format--org-region for some reason, but this is quite handy and, as far as I am concerned, I use it every day. Can i add it back in this module?