Skip to content

Add julia +snail #6578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jul 24, 2023
Merged

Add julia +snail #6578

merged 16 commits into from
Jul 24, 2023

Conversation

edmundmiller
Copy link
Member

Julia Module Refactor

  • I searched the issue tracker and this hasn't been PRed before.
  • My commits conform to the git conventions.
  • I am blindly checking these off.
  • This a draft PR; I need more time to finish it.

@jeetelongname
Copy link
Member

Just a heads up, until rewrite docs is merged, doc PRs should go into another PR targeting rewrite-docs

also CC @tecosaur

@hlissner hlissner added is:feature Adds or requests new features, or extends existing ones module:lang/julia Pertains to Doom's :lang julia module labels Jul 22, 2022
@edmundmiller edmundmiller force-pushed the julia-snail branch 4 times, most recently from 506c810 to a0efeb4 Compare July 25, 2022 02:05
@edmundmiller edmundmiller marked this pull request as ready for review July 25, 2022 02:05
@edmundmiller
Copy link
Member Author

Just a heads up, until rewrite docs is merged, doc PRs should go into another PR targeting rewrite-docs

also CC @tecosaur

Appreciate it, I didn't think it was adding much, so if you want me to take them out I certainly will, and we'll make an issue to add the documentation for it.

@jeetelongname
Copy link
Member

Its not about size but merge conflicts, by freezing docs in master it can eliminate a lot of that.

plus the format is different in subtle ways meaning it makes sense to send doc updates to rewrite-docs instead. In any case this can come later, just mentioning it now for posterity

@edmundmiller edmundmiller mentioned this pull request Jul 26, 2022
Open
@edmundmiller
Copy link
Member Author

Sounds good, thanks for the explanation! I removed them and made an issue to go back and add some more docs on what it's doing once we iron this out.

@iyefrat
Copy link
Member

iyefrat commented Aug 16, 2022

By the way, now that rewrite-docs is merged you can add the docs changes back in

@edmundmiller edmundmiller force-pushed the julia-snail branch 2 times, most recently from f2cc815 to dfe6dac Compare August 18, 2022 02:01
@edmundmiller edmundmiller changed the title Julia Module Refactor Add julia +snail Sep 15, 2022
@edmundmiller edmundmiller force-pushed the julia-snail branch 2 times, most recently from b911370 to f1929db Compare February 21, 2023 21:42
edmundmiller added 13 commits June 2, 2023 17:31
@edmundmiller
fix(julia): update eglot environment discovery
5ab4527
@edmundmiller
fix(julia): add check for vterm for snail
6b9ce02
@edmundmiller
feat(julia): add snail repl mode keybindings
f2c75de
@edmundmiller
feat(julia): use julia-snail as repl when +snail
ed4d12d
@edmundmiller
feat(julia): add snail keybindings to snail repl mode
d10bb6d
@edmundmiller
nit(julia): add note about send-region/buffer not working quite right
71c2100
@edmundmiller
fix(julia): use cider result face for snail popup
de434f5
@edmundmiller
docs(julia): add notes about +snail flag
727cb23
@edmundmiller
docs(julia): add keybindings
9a3e950
@edmundmiller
fix(julia): featurep! => modulep!
1b3bc7b
@edmundmiller
bump: :lang julia
85f8121 
JuliaEditorSupport/julia-emacs@47f43f7d8390 -> JuliaEditorSupport/julia-emacs@adf4029be778
gcv/julia-snail@326da9a7d046 -> gcv/julia-snail@0e6fa5180447
non-Jedi/eglot-jl@2e35cf9768d9 -> non-Jedi/eglot-jl@07edf37eab53
@edmundmiller
nit(julia): Format keybindings
76c1330
@edmundmiller
bump: :lang julia
8daa99f 
JuliaEditorSupport/julia-emacs@7aafa8e77df6 -> JuliaEditorSupport/julia-emacs@b35e668d6bcf
gcv/julia-snail@0e6fa5180447 -> gcv/julia-snail@c33663abf081
gdkrmr/lsp-julia@d6688bb131ff -> gdkrmr/lsp-julia@c584f79c7fee
non-Jedi/eglot-jl@2e0459722355 -> non-Jedi/eglot-jl@7dc604fe42a4
tpapp/julia-repl@57a15dfafed6 -> tpapp/julia-repl@9503ef711073
hlissner
hlissner requested changes Jul 24, 2023
View reviewed changes
Copy link
Member

@hlissner hlissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the state of this PR? At a glance, it seems merge-ready; if you think it's in good enough shape (whether or not it's done), I'd be happy to merge it now and work on it from there.

@edmundmiller
Copy link
Member Author

Merge away! I've been using it with no major issues, so I'd like to see others opinions and iteration on it(@tecosaur)

@hlissner hlissner added this to the modules v23.07 milestone Jul 24, 2023
@hlissner hlissner merged commit 06c891e into doomemacs:master Jul 24, 2023
@hlissner
Copy link
Member

Perfect! Thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlissner hlissner hlissner approved these changes

Assignees
No one assigned
Labels
is:feature Adds or requests new features, or extends existing ones module:lang/julia Pertains to Doom's :lang julia module
Projects
None yet
Milestone
modules v23.08
Development

Successfully merging this pull request may close these issues.
4 participants
@edmundmiller @jeetelongname @iyefrat @hlissner