bump: :tools biblio #6628
Merged
bump: :tools biblio #6628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdarcus
force-pushed
the
citar-update-20220803
branch
2 times, most recently
from
9451d3c to
331e477
Compare
hlissner
added
is:update
bdarcus
force-pushed
the
citar-update-20220803
branch
from
331e477 to
c3145f4
Compare
hlissner
requested changes
Aug 4, 2022
There was a problem hiding this comment.
Looks good to me so far. Just two minor nits:
- Please remove the redundant
tmalsburg/helm-bibtex@aa775340ba69 -> tmalsburg/helm-bibtex@ce8c17690ddaline in the commit. - Please add
citar-embarkandparsebibto the module's README (might have to rebase the module back ontomaster, since I updated it to the new format in 304774c).
bdarcus
force-pushed
the
citar-update-20220803
branch
2 times, most recently
from
4c4d2ec to
4653136
Compare
Done. Is it OK if we wait a couple/few days for me to mark this for review? The commits I'm waiting for are from parsebib and citar, which should address a performance issue particularly noticeable with very large files. |
bdarcus
force-pushed
the
citar-update-20220803
branch
from
4653136 to
150147c
Compare
Certainly. Take your time. I don't generally merge draft PRs. |
andras-simonyi/citeproc-el@9f783967c190 -> andras-simonyi/citeproc-el@406bd9964f1c emacs-citar/citar@b24b5b94b7d5 -> emacs-citar/citar@146f2cb5a31d tmalsburg/helm-bibtex@aa775340ba69 -> tmalsburg/helm-bibtex@ce8c17690dda Also add citar-embark, which now contains the embark functionality in a separate minor mode package, and explicitly add parsebib, so we can pin the precise version.
bdarcus
force-pushed
the
citar-update-20220803
branch
from
150147c to
98aef02
Compare
hlissner
approved these changes
Aug 8, 2022
|
Understood. And everything else looks good. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the biblio module, which also requires adding
citar-embark, which now contains the embark functionality in a separate minor mode package. Also, add an explicit parsebib package line to pin it.Also, close #6464