Skip to content

fix(layout): Bépo rotation happening before magit #6746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

gagbo
Copy link
Member

@gagbo gagbo commented Sep 2, 2022

Fixes an issue where binding rotations in Bépo were happening too soon,
resulting in some remaps not being visible to the user when interacting
with magit, :editor evil +everywhere, and :input layout +bepo

Ref: https://discourse.doomemacs.org/t/layout-bepo-does-not-properly-remap-k-in-magit/3063

@gagbo gagbo requested a review from a team as a code owner September 2, 2022 15:31
@gagbo gagbo added re:evil Related to vim/evil usage and users module:input/layout Pertains to Doom's :input layout module labels Sep 2, 2022
@gagbo gagbo force-pushed the fix/bepo-magit branch 5 times, most recently from 15b74fc to 638edbc Compare September 11, 2022 15:45
Fixes an issue where binding rotations in Bépo were happening too soon,
resulting in some remaps not being visible to the user when interacting
with magit, :editor evil +everywhere, and :input layout +bepo

Ref: https://discourse.doomemacs.org/t/layout-bepo-does-not-properly-remap-k-in-magit/3063
@hlissner hlissner added this to the modules v22.09 milestone Sep 16, 2022
@hlissner hlissner added the is:bug Something isn't working as intended label Sep 16, 2022
@hlissner hlissner merged commit 559229c into doomemacs:master Sep 16, 2022
@hlissner
Copy link
Member

Good work, as always! Thanks again!

@gagbo gagbo deleted the fix/bepo-magit branch September 16, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug Something isn't working as intended module:input/layout Pertains to Doom's :input layout module re:evil Related to vim/evil usage and users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants