Skip to content

Conversation

@Sleepful
Copy link
Contributor

@Sleepful Sleepful commented Oct 18, 2022

(when (display-graphic-p)) is always nil for terminal emacs

I tested it on my machine, I run emacs as daemon in kitty terminal.

Before this change:

  • start emacs
  • highlight-indent-guides-mode is on (through :ui indent-guides)
  • however there are no indent lines visible
  • changing doom themes manually with load-theme allows indent guides to be shown. Manually calling highlight-indent-guides-auto-set-faces has the same effect.

After change:

  • start emacs
  • indent-guides are displayed on files without any issue

  • I searched the issue tracker and this hasn't been PRed before.
  • My commits conform to the git conventions.
  • My changes are visual; I've included before and after screenshots.
  • I am blindly checking these off. 🤣

`(when (display-graphic-p))` is always `f` for terminal emacs
@hlissner hlissner added is:bug Something isn't working as intended module:ui/indent-guides Pertains to Doom's :ui indent-guides module labels Oct 22, 2022
@hlissner hlissner added this to the modules v22.10 milestone Oct 22, 2022
@hlissner hlissner added the was:moved Is, was, or will be addressed elsewhere label Oct 27, 2022
@hlissner hlissner closed this in 9d4689d Oct 28, 2022
@hlissner
Copy link
Member

As of 9d4689d this should be resolved. Thanks for your help! Let me know if it doesn't fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is:bug Something isn't working as intended module:ui/indent-guides Pertains to Doom's :ui indent-guides module was:moved Is, was, or will be addressed elsewhere

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants