Skip to content

refactor!: replace all-the-icons with nerd-icons #7411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 13, 2023
Merged

refactor!: replace all-the-icons with nerd-icons #7411

merged 5 commits into from
Sep 13, 2023

Conversation

elken
Copy link
Contributor

@elken elken commented Sep 12, 2023

Commits will likely need rebasing in some form, but I've gone through and tested as much as I can.

Per discussion on Discord, we can either disable all-the-icons here or in a future PR down the line; makes no difference to me

@elken elken requested review from a team as code owners September 12, 2023 14:32
@elken elken marked this pull request as draft September 12, 2023 14:32
@elken elken marked this pull request as ready for review September 12, 2023 14:32
@hlissner hlissner linked an issue Sep 12, 2023 that may be closed by this pull request
doom-modeline now uses nerdfonts #7368
Closed
4 tasks
@hlissner hlissner added this to the modules v23.09 milestone Sep 12, 2023
@hlissner hlissner added ! Introduces, suggests, or requires a backwards-incompatible change is:refactor Code changes with little/no effect on user-facing behavior labels Sep 12, 2023
@elken elken mentioned this pull request Sep 12, 2023
Merged
24 tasks
hlissner
hlissner requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@hlissner hlissner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the doom-ui scope from 483836d's commit message? Changes to core should have no scope (except for lib for the stuff in lisp/lib/*.el).

Actually, scratch that. I'll likely squash this PR, and will correct it then.

@elken
Copy link
Contributor Author

elken commented Sep 13, 2023

Could you remove the doom-ui scope from 483836d's commit message? Changes to core should have no scope (except for lib for the stuff in lisp/lib/*.el).

Actually, scratch that. I'll likely squash this PR, and will correct it then.

Yeah this should probably be 1 commit, I just wanted to split it up in case there were breaking changes with ivy/helm/company since they were more involved than simple changes

@hlissner hlissner changed the title Migrate all-the-icons to nerd-icons refactor!: replace all-the-icons with nerd-icons Sep 13, 2023
@hlissner hlissner merged commit 9787022 into doomemacs:master Sep 13, 2023
@hlissner hlissner mentioned this pull request Sep 13, 2023
Closed
4 tasks
hlissner pushed a commit that referenced this pull request Sep 14, 2023
@SunskyXH
fix(tabs): replace all-the-icons with nerd-icons
0c79390 
Ref: #7411
hlissner pushed a commit that referenced this pull request Sep 14, 2023
@elken
fix: nerd-icons-material => nerd-icons-mdicon
e97b05c 
Fix: #7422
Amend: #7411
hlissner added a commit that referenced this pull request Sep 15, 2023
@hlissner
fix(treemacs): replace all-the-icons with nerd-icons
57965f1 
Ref: #7411
Close: #7428
Ref: https://discourse.doomemacs.org/t/4147
This was referenced Sep 15, 2023
Closed
Closed
peterhoeg pushed a commit to peterhoeg/doomemacs that referenced this pull request Sep 17, 2023
@SunskyXH @peterhoeg
fix(tabs): replace all-the-icons with nerd-icons
3f6b6a0 
Ref: doomemacs#7411
peterhoeg pushed a commit to peterhoeg/doomemacs that referenced this pull request Sep 17, 2023
@hlissner @peterhoeg
fix(treemacs): replace all-the-icons with nerd-icons
54c5077 
Ref: doomemacs#7411
Close: doomemacs#7428
Ref: https://discourse.doomemacs.org/t/4147
This was referenced Sep 21, 2023
Closed
Merged
Closed
kenranunderscore pushed a commit to kenranunderscore/doomemacs that referenced this pull request Oct 16, 2023
@SunskyXH @kenranunderscore
fix(tabs): replace all-the-icons with nerd-icons
05f7660 
Ref: doomemacs#7411
kenranunderscore pushed a commit to kenranunderscore/doomemacs that referenced this pull request Oct 16, 2023
@elken @kenranunderscore
fix: nerd-icons-material => nerd-icons-mdicon
cf71ddc 
Fix: doomemacs#7422
Amend: doomemacs#7411
kenranunderscore pushed a commit to kenranunderscore/doomemacs that referenced this pull request Oct 16, 2023
@hlissner @kenranunderscore
fix(treemacs): replace all-the-icons with nerd-icons
1f87534 
Ref: doomemacs#7411
Close: doomemacs#7428
Ref: https://discourse.doomemacs.org/t/4147
Zetagon pushed a commit to Zetagon/doom-emacs that referenced this pull request Oct 17, 2023
@SunskyXH
fix(tabs): replace all-the-icons with nerd-icons
7e81a2b 
Ref: doomemacs#7411
Zetagon pushed a commit to Zetagon/doom-emacs that referenced this pull request Oct 17, 2023
@elken
fix: nerd-icons-material => nerd-icons-mdicon
c53a436 
Fix: doomemacs#7422
Amend: doomemacs#7411
Zetagon pushed a commit to Zetagon/doom-emacs that referenced this pull request Oct 17, 2023
@hlissner
fix(treemacs): replace all-the-icons with nerd-icons
5a08413 
Ref: doomemacs#7411
Close: doomemacs#7428
Ref: https://discourse.doomemacs.org/t/4147
@heyste heyste mentioned this pull request Nov 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlissner hlissner hlissner approved these changes

Assignees
No one assigned
Labels
! Introduces, suggests, or requires a backwards-incompatible change is:refactor Code changes with little/no effect on user-facing behavior
Projects
None yet
Milestone
modules v24.02
Development

Successfully merging this pull request may close these issues.

doom-modeline now uses nerdfonts
2 participants
@elken @hlissner