fix(cli): some package files not being byte-compiled (2nd take) #8247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts a workaround for straight that is no longer necessary because it has been applied upstream and we've bumped the package since. For some reason I don't understand, this reproducibly fixes a reoccurrence of the original problem for me: Before this commit, some files of the citar package were not byte-compiled. After this commit, the problem is gone. This effectively reverts 54a084f, though it's not a reverting commit in strict sense because the code has been moved to a different file. Revert: 54a084f Ref: d80c5e5 Ref: doomemacs#7707 Ref: radian-software/straight.el#1132 Ref: https://discourse.doomemacs.org/t/is-it-expected-that-doom-sync-does-not-byte-compile-native-compile-some-files/4946
hlissner
added
is:bug
hlissner
approved these changes
Jan 17, 2025
real-or-random
force-pushed
the
202501-byte-compile-cli
branch
from
ad690c1 to
22f1d20
Compare
|
Sorry, force-pushed just to improve the commit message. Ready now. |
|
LGTM! Thanks again for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a workaround for straight that is no longer necessary because it has been applied upstream and we've bumped the package since.
For some reason I don't understand, this reproducibly fixes a reoccurrence of the original problem for me: Before this commit, some files of the citar package were not byte-compiled. After this commit,the problem is gone.
This effectively reverts 54a084f, though it's not a reverting commit in strict sense because the code has been moved to a different file.
Revert: 54a084f
Ref: d80c5e5
Ref: #7707
Ref: radian-software/straight.el#1132
Ref: https://discourse.doomemacs.org/t/is-it-expected-that-doom-sync-does-not-byte-compile-native-compile-some-files/4946