Certain Neotree icons cannot be displayed

[ppwwyyxx]

I've install fonts from all-the-icons, and after (setq doom-neotree-file-icons t), I can see icons for most filetypes except for certain files:

Then I modified modules/ui/doom/config.el and remove the doom-themes-neotree-config hook, the icons for Makefile and LICENSE are back, just like the official neotree screenshot: https://github.com/jaypei/emacs-neotree/blob/dev/screenshots/icons.png

So it seems like doom-themes-neotree has some issues with files without extensions.

[hlissner]

Is there any reason you can't use (setq neo-theme 'icons) instead of doom-themes-neotree-config?

I've been meaning to phase out support for (setq doom-neotree-file-icons t), because it does little that neotree's icon theme can't. Rather, the purpose of doom-themes-neotree-config is to provide a minimalistic icon theme (ala atom), e.g.

This is meant as an alternative to neotree's full-blown icon theme.

[ppwwyyxx]

(setq neo-theme 'icons) seems to have the same issue.

[hlissner]

Even with doom-themes-neotree-config removed from your config?

[ppwwyyxx]

When doom-themes-neotree-config was removed things work fine.
Do you mean that I should just disable it if I want icons?

[hlissner]

Yes, if you want icons-by-filetype (like in your post), use (setq neo-theme 'icons) without doom-themes-neotree-config.

But if you want atom-style icons (like in my post above), use

(doom-themes-neotree-config)
;; this isn't necessary, because 'simple is the default
(setq doom-neotree-file-icons 'simple)

[ppwwyyxx]

Thanks! I end up with

(def-package-hook! doom-themes
  :post-config
  (remove-hook 'doom-load-theme-hook #'doom-themes-neotree-config)
)

[hlissner]

Oh! I wasn't aware you were a Doom user. In that case, I'd recommend doing it this way:

(after! doom-themes
  (remove-hook 'doom-load-theme-hook #'doom-themes-neotree-config))

It is functionally equivalent, but after! is generally more preformant than (def-package-hook! X :post-config ...).

[jupl]

I'm pretty bummed out by this move, unfortunately after updating recently. If I don't use doom-themes-neotree-config I lose the nice customizations that were offered by doom.

However, when I use doom-themes-neotree-config I don't get any of the file icons that are useful at a glance, even with the neo-theme option.

Is there any way to get the best of both worlds like how it used to work?

[hlissner]

@jupl Sorry about that. To remove it entirely was too hasty a decision. I'll revisit this in the next day or two and bring doom-themes-neotree-config up to snuff so I can restore that feature.

[rickithadi]

@hlissner any updates on this?

[jesusbv]

Thank you for the package and the efforts on this repo @hlissner

I would like to ask if it is possible to extend/add more icons ?

for example, without

(doom-themes-neotree-config)

with

(doom-themes-neotree-config)
(setq doom-themes-neotree-file-icons t)

Most of icons are there but some are missing