Changing header metadata to show correct information with sharing. #517

Merged
merged 1 commit into from Jul 16, 2016

Projects

None yet

3 participants

@devleoper
Collaborator
devleoper commented Jul 16, 2016 edited

Changing og:url value to URL of each page will help showing information in Open Graph correctly. (Currently if we share any page to Facebook, we will see same previews because og:url points only the main page.)

And changed description and og:description to show translated description of Elixir School.

Where can we go further?

We can set descriptions which make summary for each page to make sneak-peeking easy.

@doomspork
Owner

This is great @devleoper!! This is good to merge from my perspective, any additional changes you'd like to make before I do so?

@devleoper
Collaborator

It's ready to be merged. I think there isn't additional thing at this time for this. 😃

@brain-geek brain-geek merged commit 96708a0 into doomspork:master Jul 16, 2016
@devleoper devleoper deleted the devleoper:enhancement/html-meta-header branch Jul 16, 2016
@rezaprima rezaprima added a commit to rezaprima/elixir-school that referenced this pull request Jul 20, 2016
@rezaprima rezaprima Merge branch 'master' of https://github.com/doomspork/elixir-school
* 'master' of https://github.com/doomspork/elixir-school: (122 commits)
  Renamed and applied enhancement for Korean Translation of Modules (#518)
  [JP] Improve translation in metaprogramming lesson (#458)
  [JP] Add description of special syntax of map (#508)
  Create spanish translation for error handling page (#389)
  [JP] Add error handling lesson (#451)
  [NO] Translation of the sections referenced in #480 and #481 (#486)
  [SK] Translation of the sections referenced in #480 and #481 (#504)
  Changed meta descriptions and og:url to show proper information. (#517)
  Stylesheets for Printers. (#520)
  Renamed "Composition" Lessons in other languages to "Modules" Lesson (#519)
  Correct the translation of "Korean" (#516)
  fix typo (#515)
  Remove duplicate from Russian glossary (#514)
  Improved "Pipe operator" lesson according to suggestion in #305 task (#511)
  Add one more step to 'new language' process (#512)
  Add more language links to main page (#510)
  [KO] Translated updating/accessing maps section into Korean (#491)
  [KO] Translation of OTP Supervisor lesson (#426)
  [KO] Translation of Concurrency lesson (#466)
  [KO] Translation of Umbrella Projects Lesson. (#490)
  ...
943e973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment