Add the new section for libraries #729

Merged
merged 2 commits into from Nov 28, 2016

Projects

WIP in New Lessons

5 participants

@nscyclone
Collaborator
nscyclone commented Oct 15, 2016 edited

During discussion in #702 we came to a decision that we need a new separate section for libraries.
This PR adds the mentioned section and it also hides the sections without lessons from the sidebar.
cc @doomspork @brain-geek @ybur-yug @Koziolek and everyone else.

Once this will be merged, #702 and #431 will require corresponding updates (location, order and category). Then I'll also create an issue for translations.

@brain-geek
Collaborator

Let's merge it with at least one lesson in this category. e.g. after #702 gets merged.

@ybur-yug

LGTM, I'm just with @brain-geek on waiting til we get atleast one item in here (i.e Poolboy once its done, which it seems to be quite close)

@Koziolek
Collaborator

Looks nice, let't merge it with first lesson plus add some info about library vs specific, because sometimes is hard to say what is what.

@doomspork

Agree with the others, let's wait to merge until we get the first lesson in.

@ybur-yug
Collaborator

Looks like we need to update the configuration for the new ruby version on Heroku to get this one synced properly with master now

@nscyclone
Collaborator

Thanks @ybur-yug!
Actually the conflict was caused by another set of changes. Anyway, I merged latest master into this branch and resolved it, so the latter one is mergeable again.

@brain-geek brain-geek referenced this pull request Nov 9, 2016
Merged

Add guardian #790

@doomspork doomspork merged commit 5b750a1 into doomspork:master Nov 28, 2016
@nscyclone nscyclone deleted the nscyclone:feature/libraries branch Nov 29, 2016
@nscyclone nscyclone referenced this pull request Nov 29, 2016
Open

Translate the new section name #834

8 of 17 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment