Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate redirect_uri when handling custom params #66

Merged
merged 1 commit into from Feb 15, 2019

Conversation

@toupeira
Copy link
Member

commented Feb 8, 2019

Fixes #61

@toupeira toupeira added the bug label Feb 8, 2019

@toupeira toupeira self-assigned this Feb 8, 2019

@toupeira toupeira requested review from nashby and nbulaj Feb 8, 2019

Validate pre_authorization when handling custom params
This fixes an open redirect vulnerability when being passed an invalid
redirect_uri, and also prioritizes any other pre-authorization
validation errors from Doorkeeper.

@toupeira toupeira force-pushed the bug/invalid-redirect-uri branch from 41687cb to 801d1d7 Feb 15, 2019

@toupeira toupeira merged commit 0267515 into master Feb 15, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@toupeira toupeira deleted the bug/invalid-redirect-uri branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.