Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XSS in default views #969

Closed
simkim opened this issue May 25, 2017 · 0 comments
Closed

XSS in default views #969

simkim opened this issue May 25, 2017 · 0 comments

Comments

@simkim
Copy link
Contributor

simkim commented May 25, 2017 •
edited

Default authorization and application views use the "raw" function which inevitably lead to xss issue :

doorkeeper/app/views/doorkeeper/authorizations/new.html.erb

Line 7 in 14c9ed1

<%= raw t('.prompt', client_name: "<strong class=\"text-info\">#{ @pre_auth.client.name }</strong>") %>

doorkeeper/app/views/doorkeeper/applications/_form.html.erb

Line 24 in 14c9ed1

<%= raw t('doorkeeper.applications.help.native_redirect_uri', native_redirect_uri: "<code>#{ Doorkeeper.configuration.native_redirect_uri }</code>") %>

simkim added a commit to simkim/doorkeeper that referenced this issue May 25, 2017
@simkim
Adding a request spec to demonstrate xss issue doorkeeper-gem#969
84fd4d0 
The client name is not escaped
@simkim simkim mentioned this issue May 25, 2017
Merged
@simkim simkim changed the title XSS in default authorization page XSS in default pages May 25, 2017
@simkim simkim changed the title XSS in default pages XSS in default views May 25, 2017
dmitrytrager pushed a commit to earlymarket/doorkeeper that referenced this issue Jun 9, 2017
@simkim @dmitrytrager
Adding a request spec to demonstrate xss issue doorkeeper-gem#969
299eefd 
The client name is not escaped
pimpin pushed a commit to teezily/doorkeeper that referenced this issue Nov 27, 2018
@simkim
Adding a request spec to demonstrate xss issue doorkeeper-gem#969
138d3b6 
The client name is not escaped
AaronBroadIntrohive pushed a commit to AaronBroadIntrohive/doorkeeper that referenced this issue May 14, 2019
@simkim @AaronBroadIntrohive
Adding a request spec to demonstrate xss issue doorkeeper-gem#969
b439dee 
The client name is not escaped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simkim