/doorkeeper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration to enforce application scopes #1010

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Reviewers

@nbulaj nbulaj

@houndci-bot houndci-bot

Assignees

@nbulaj nbulaj

Labels
Projects
None yet
Milestone
  5.0
3 participants
@talklittle @nbulaj @houndci-bot
@talklittle
Contributor

talklittle commented Jan 3, 2018

Fixes #1009
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated lib/doorkeeper/models/application_mixin.rb
Show outdated Hide outdated lib/doorkeeper/models/application_mixin.rb
Show outdated Hide outdated lib/doorkeeper/models/application_mixin.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb

@nbulaj nbulaj added the bug? label Feb 4, 2018

@talklittle

This comment has been minimized.

Show comment
Hide comment
@talklittle

talklittle Feb 15, 2018

Contributor

@nbulaj Rebased to fix conflicts with master.
Contributor

talklittle commented Feb 15, 2018

@nbulaj Rebased to fix conflicts with master.

talklittle added a commit to talklittle/lobsters that referenced this pull request Feb 26, 2018

@talklittle
oauth: require predefined scopes for applications 
not yet merged into Doorkeeper as of 4.3.0,
so temporarily pointing to a git branch.

see doorkeeper-gem/doorkeeper#1010
d981b06

talklittle added a commit to talklittle/lobsters that referenced this pull request Mar 8, 2018

@talklittle
oauth: require predefined scopes for applications 
not yet merged into Doorkeeper as of 4.3.1,
so temporarily pointing to a git branch.

see doorkeeper-gem/doorkeeper#1010
7e1e589

@nbulaj nbulaj self-assigned this Mar 12, 2018

@nbulaj nbulaj added this to the 5.0 milestone Mar 12, 2018

Show outdated Hide outdated lib/doorkeeper/orm/active_record/application.rb
Show outdated Hide outdated lib/doorkeeper/orm/active_record/application.rb
Show outdated Hide outdated lib/doorkeeper/orm/active_record/application.rb
spec/requests/applications/applications_request_spec.rb
end
scenario "adding app validating scope, blank scope is accepted" do
config_is_set("enforce_configured_scopes", true)

This comment has been minimized.

Show comment
Hide comment
@nbulaj

nbulaj Mar 12, 2018

Member

Let's add a test with multiple scopes to be sure everything is OK
Copy URL
@nbulaj

nbulaj Mar 12, 2018

Member

Let's add a test with multiple scopes to be sure everything is OK
@nbulaj

This comment has been minimized.

Show comment
Hide comment
@nbulaj

nbulaj Mar 12, 2018

Member

Hi @talklittle . Could you please take an attention to my comments below? Also could you please add an entry to NEWS.md file and squash all the commits to a single one? Thanks!
Member

nbulaj commented Mar 12, 2018

Hi @talklittle . Could you please take an attention to my comments below? Also could you please add an entry to NEWS.md file and squash all the commits to a single one? Thanks!

@nbulaj nbulaj added enhancement and removed bug? labels Mar 12, 2018

Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated spec/requests/applications/applications_request_spec.rb
Show outdated Hide outdated lib/doorkeeper/orm/active_record/application.rb
Show outdated Hide outdated lib/doorkeeper/orm/active_record/application.rb
Show outdated Hide outdated lib/doorkeeper/orm/active_record/application.rb
@talklittle

This comment has been minimized.

Show comment
Hide comment
@talklittle

talklittle Mar 14, 2018

Contributor

@nbulaj Thanks for review. Applied your feedback.
Contributor

talklittle commented Mar 14, 2018

@nbulaj Thanks for review. Applied your feedback.

@nbulaj nbulaj merged commit 829772b into doorkeeper-gem:master Mar 16, 2018
2 of 3 checks passed

2 of 3 checks passed

coverage/coveralls Coverage decreased (-0.05%) to 98.148%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
hound No violations found. Woof!
@nbulaj

This comment has been minimized.

Show comment
Hide comment
@nbulaj

nbulaj Mar 16, 2018

Member

Thank you @talklittle 👍
Member

nbulaj commented Mar 16, 2018

Thank you @talklittle 👍

talklittle added a commit to talklittle/lobsters that referenced this pull request Mar 28, 2018

@talklittle
oauth: require predefined scopes for applications 
not yet merged into Doorkeeper as of 4.3.1,
so temporarily pointing to a git branch.

see doorkeeper-gem/doorkeeper#1010
dc2d508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment