Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Forward with subPath #94

Merged
merged 1 commit into from Sep 19, 2016
Merged

fix Forward with subPath #94

merged 1 commit into from Sep 19, 2016

Conversation

saiyagg
Copy link
Contributor

@saiyagg saiyagg commented Sep 14, 2016

修复类似如下加上请求方法的规则下,路径替换错误的问题

'GET /someDir/(.*)': 'https://g.alicdn.com/tb-page/taobao-home/',

@coveralls
Copy link

coveralls commented Sep 14, 2016

Coverage Status

Coverage decreased (-8.1%) to 81.707% when pulling f676fa4 on saiyagg:master into 8105539 on dora-js:master.

@sorrycc sorrycc merged commit 5872ad6 into dora-js:master Sep 19, 2016
@saiyagg
Copy link
Contributor Author

saiyagg commented Sep 20, 2016

我看看

@@ -118,7 +118,7 @@ export default function(args) {
if (proxyConfig.hasOwnProperty(pattern)) {
const subPath = getSubPath(option, pattern);
if (subPath) {
retPath = retPath.replace(RegExp(pattern), '/' + subPath);
retPath = winPath(join(proxyConfig(pattern), subPath))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像是有问题。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯, 我修改下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants