sox_add_effect error handling fix

erikronstrom · erikronstrom · commit 0c21d469245c · 2024-02-27T10:32:37.000+01:00
diff --git a/src/effects.c b/src/effects.c
@@ -188,6 +188,7 @@ int sox_add_effect(sox_effects_chain_t * chain, sox_effect_t * effp, sox_signali
   }
   if (ret != SOX_SUCCESS) {
     free(eff0.priv);
+    effp->priv = NULL; /* Avoid bad calls to free in sox_delete_effect */
     return SOX_EOF;
   }
   if (in->mult)

Original file line number	Diff line number	Diff line change
`@@ -188,6 +188,7 @@ int sox_add_effect(sox_effects_chain_t * chain, sox_effect_t * effp, sox_signali`
`188`	`188`	`}`
`189`	`189`	`if (ret != SOX_SUCCESS) {`
`190`	`190`	`free(eff0.priv);`
	`191`	`+ effp->priv = NULL; /* Avoid bad calls to free in sox_delete_effect */`
`191`	`192`	`return SOX_EOF;`
`192`	`193`	`}`
`193`	`194`	`if (in->mult)`