-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retina graphics and related fixes #17
Conversation
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
- No need to append ".png", NSImage will do this (or any other extension, such as .tiff) by itself if needed. Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
- Changed the field to be bordered which solved the issue. Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
- As no PSD were available I had to remake it from scratch, will have to do the same with all other images. Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
- This meant not just replacing the old images but also re-creating the buttons in Interface Builder. They are now inside a segmented button instead of two separate butcons. Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
- For HiDPI images. Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
- The new icon works with HiDPI. - Now uses the modern `.iconset` format, which I believe requires Xcode 4.4. - Xcode also decided that almost all key-value paris had to be re-arranged… Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
- The new icon works with HiDPI and is based on the new App Icon (see commit 76df9d3). - Now uses the modern `.iconset` format, which I believe requires Xcode 4.4. Signed-off-by: Aron Cedercrantz <aron@cedercrantz.se>
Wow, this looks fantastic! Thank you so much! I'll take a closer look and merge it today. |
Just tried this out on my rMBP, and it looks superb. Great job! Is there any good reason I shouldn't only include the @2x icons? I don't see any good reason to include pre-scaled copies if they're not hinted differently. |
Retina graphics and related fixes
The @1x images have been optimised a slight bit (the shapes were snapped to pixels during the output phase). I haven’t checked how it looks with just the @2x images (rescaled by Cocoa) though so that might look better? (Hope not, as that would mean I wasted time re-scaling images :-)) Glad you liked them and seeing them merged! |
Noted, will try to get the 1x images to work. I couldn't get the iconset to work as the app icon -- I realize now that this is probably because I'm on the older version of Xcode? If that's the case, I'll simply restore the iconsets when I upgrade. |
Yea I think the iconset format requires Xcode 4.4, which should land on the app store some time later this month presumably. |
As a little (split) weekend project I’ve updated all images used in the GUI of CoRD for HiDPI/retina. As I did not find the original artwork until way to late I have re-created each image (except the clock image which I just scaled as I couldn’t manage to get it to show in the UI). I tried to make the new images somewhat similair to the old but they do deviate.
I also changed the next/previous standalone buttons into a single segmented button with template images.
Furthermore I’ve made a new application icon which contains all the sizes required of an icon on OS X and then used this as a base for the new document icons. The new application and document icons use the new iconset format which means that Xcode 4.4 will probably be required to compile the project. Xcode 4.3 might work but I haven’t tested.
I’ve also modified the disk image background so that it should work on retina displays. You can download the PSD,
1x
and2x
PNG images as a ZIP.It should probably be noted that this does not fix all issues with HiDPI I’ve encountered (such as moving an active session to a HiDPI screen and then back again, the window shrinks :-))
The new application icon (512x512@1x):