-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This should work #16
Merged
Merged
This should work #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will need to try it in the evening, busy day.
…On Tue, Nov 6, 2018, 12:52 AM John Muschelli ***@***.*** wrote:
Have the code for resampleImageToTarget , but I think that may screw up
the origins. Overall this works, the package should check out, and the
resulting segmentation is "okay". The registrations seem off back to native
though.
------------------------------
You can view, comment on, or merge this pull request online at:
#16
Commit Summary
- fixing some fo the namespace and such
- fixing the linda
- removed tests and documented asym mask
- added asym rd and voxchunk arg
- using resampleImagetoTarget instead
- fixing n4_skull_strip
- reverting back to resampleImage - maybe thats OK?
- fix nm again
- removing LINDA files as they do not pass R CMD check
File Changes
- *M* DESCRIPTION
<https://github.com/dorianps/LINDA/pull/16/files#diff-0> (6)
- *M* NAMESPACE
<https://github.com/dorianps/LINDA/pull/16/files#diff-1> (10)
- *M* R/asymmetry_mask.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-2> (22)
- *D* R/compose_warping.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-3> (26)
- *M* R/getLesionFeatures.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-4> (5)
- *M* R/linda_predict_function.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-5> (56)
- *D* R/mrvnrfs_chunks.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-6> (399)
- *A* R/mrvnrfs_predict_chunks.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-7> (206)
- *M* R/n4_skull_strip.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-8> (3)
- *M* R/run_prediction.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-9> (23)
- *D* man/LINDA.mrvnrfs_chunks.Rd
<https://github.com/dorianps/LINDA/pull/16/files#diff-10> (82)
- *A* man/asymmetry_mask.Rd
<https://github.com/dorianps/LINDA/pull/16/files#diff-11> (26)
- *R* man/linda_mrvnrfs.predict_chunks.Rd
<https://github.com/dorianps/LINDA/pull/16/files#diff-12> (17)
- *M* original/linda_predict.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-13> (45)
- *M* original/mrvnrfs_chunks.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-14> (227)
- *A* original/mrvnrfs_chunks_predict.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-15> (164)
- *D* tests/testthat.R
<https://github.com/dorianps/LINDA/pull/16/files#diff-16> (4)
Patch Links:
- https://github.com/dorianps/LINDA/pull/16.patch
- https://github.com/dorianps/LINDA/pull/16.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#16>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIqafTLXxrIvRgbPgzjfy9BAn79nkGFvks5usSOXgaJpZM4YPzIO>
.
|
muschellij2
pushed a commit
to muschellij2/LINDA
that referenced
this pull request
Apr 20, 2020
This should work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the code for resampleImageToTarget , but I think that may screw up the origins. Overall this works, the package should check out, and the resulting segmentation is "okay". The registrations seem off back to native though.