From eba8931d4c2cbe5b87c457a9e41eae8940ba62ee Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Sun, 7 Jan 2024 10:28:52 +0200 Subject: [PATCH] python310Packages.matplotlib: comments fixes The link to the build docs is outdated, and it doesn't have an updated direct alternative. While I tried to enable at least some of the tests, I encountered https://github.com/NixOS/nixpkgs/issues/255262 which is now linked in a comment. --- pkgs/development/python-modules/matplotlib/default.nix | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkgs/development/python-modules/matplotlib/default.nix b/pkgs/development/python-modules/matplotlib/default.nix index bad385ee3ad95c..8fb5c7c292cf87 100644 --- a/pkgs/development/python-modules/matplotlib/default.nix +++ b/pkgs/development/python-modules/matplotlib/default.nix @@ -6,7 +6,6 @@ , isPyPy , pythonOlder -# https://github.com/matplotlib/matplotlib/blob/main/doc/devel/dependencies.rst # build-system , certifi , pkg-config @@ -182,8 +181,10 @@ buildPythonPackage rec { env.MPLSETUPCFG = writeText "mplsetup.cfg" (lib.generators.toINI {} passthru.config); - # Matplotlib needs to be built against a specific version of freetype in - # order for all of the tests to pass. + # Encountering a ModuleNotFoundError, as describved and investigated at: + # https://github.com/NixOS/nixpkgs/issues/255262 . It could be that some of + # which may fail due to a freetype version that doesn't match the freetype + # version used by upstream. doCheck = false; meta = with lib; {