Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regressions in video recording #1400

Merged
merged 20 commits into from Nov 28, 2021
Merged

Fix regressions in video recording #1400

merged 20 commits into from Nov 28, 2021

Conversation

kcgen
Copy link
Member

@kcgen kcgen commented Nov 28, 2021

Fixes regressions introduced in ZMBV recording. Thanks to @Grounded0 for reporting and regression testing.

Segfault on out-of-bound write

2021-11-27_21-31

Undefined behavior (shifting negative values and overflows)

2021-11-27_21-30

Out-of-bounds memory read

2021-11-27_21-24

Memory Leaks

2021-11-27_21-40

@kcgen kcgen self-assigned this Nov 28, 2021
@kcgen kcgen added the regression We broke something 😊 label Nov 28, 2021
@kcgen kcgen added this to In progress in 0.78 release via automation Nov 28, 2021
Fixes LGTM warning:

  Multiplication result may overflow 'int' before it is
  converted to 'FrameBlock_offset'.
@dosbox-staging dosbox-staging deleted a comment from lgtm-com bot Nov 28, 2021
@kcgen kcgen merged commit eddafd0 into main Nov 28, 2021
0.78 release automation moved this from In progress to Done Nov 28, 2021
@kcgen kcgen deleted the kc/zmbv-recording-1 branch November 28, 2021 08:01
@kcgen kcgen added this to the 0.78 release milestone Dec 21, 2021
@kcgen kcgen changed the title Fix regressions introduces in video recording Fix regressions in video recording Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression We broke something 😊
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant