New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regressions in video recording #1400
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enum classes will error-out at compile time if an integer is attempted to be used in place of the enum.
Also adds a FinishVideo() function to cleanup the zlib compressor.
This avoids many signed and unsigned comparisons as well as implicit casts.
kcgen
force-pushed
the
kc/zmbv-recording-1
branch
from
November 28, 2021 07:06
43278db
to
9a00376
Compare
Fixes LGTM warning: Multiplication result may overflow 'int' before it is converted to 'FrameBlock_offset'.
kcgen
force-pushed
the
kc/zmbv-recording-1
branch
from
November 28, 2021 07:54
9a00376
to
235a0cc
Compare
kcgen
changed the title
Fix regressions introduces in video recording
Fix regressions in video recording
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regressions introduced in ZMBV recording. Thanks to @Grounded0 for reporting and regression testing.
Segfault on out-of-bound write
Undefined behavior (shifting negative values and overflows)
Out-of-bounds memory read
Memory Leaks