Make memory arrays static #1714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kklobe
force-pushed
the
kk/memory-static-alloc
branch
5 times, most recently
from
9103878 to
fa83113
Compare
kcgen
added
cleanup
kklobe
force-pushed
the
kk/memory-static-alloc
branch
from
fa83113 to
555be4c
Compare
kcgen
reviewed
Jun 9, 2022
kklobe
force-pushed
the
kk/memory-static-alloc
branch
from
555be4c to
3a64640
Compare
kcgen
reviewed
Jun 9, 2022
kcgen
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was looking through the paging and memory subsystems for troubleshooting the First Encounter crash on ARM systems, I noticed that while the
paging.tlbarrays are statically allocated, the mainMemBasememory block array isn't.I made a simple change to make the arrays statically allocated. While I did not see a performance difference, I like the idea of automatic memory management and reducing the burden on the heap allocator.
This did not increase memory usage (under macOS), even though the full 64M
MAX_MEMORYis reserved, because the unused range abovememsizefromdosbox.confis never written.