Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
locales.conf: add some country numbers [#1579]
@bk could you please check/add more of those?
- Loading branch information
Showing
1 changed file
with
25 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eebc4f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's your source for the country numbers? I found this list for MS DOS 6.22: http://alvarestech.com/temp/DriveKey/dos/country.txt. According to that e.g.
en_CA
(Canadian English) should be 4 andfr_CA
(Canadian French) should be 2 (instead of the 1 and 2, respectively, in this commit).Generally, the numbers are telephone country calling codes, so in most cases the blanks can be easily filled out by looking at the second ("YY") part of the "xx_YY"
lang
value. Sois_IS
is 354,de_AT
is 43, etc. The only slight problem with this schema arises when a country has more than one official language (like Canada).eebc4f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You state fr_CA as "should be 2" and "is 2", so I wonder
what is the problem with it.
en_CA indeed should be 4, its just that this table:
https://github.com/dosemu2/fdpp/blob/master/kernel/config.c#L2851
doesn't have 4. We nevertheless should of
course use the right values.
@andrewbird you recently wanted to embed
country.sys to fdpp (before we found the one
already there). Would you like to look at merging
the table of full country.sys to ours?
eebc4f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you propose to match the YY
value to the line of the table you've found (thanks!)?
eebc4f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, it's not possible directly. One would have to find the two-letter code by searching for the country name in a good list of country ISO codes such as this one on Wikipedia. For the countries listed in the MSDOS 6.22 file, this yields:
There are some additional entries in
country.txt
which cannot be directly mapped using the above method:country.txt
, 785, does not exist as an international phone prefix. It may have been chosen because both Tunisia and the UAE have a numeric ISO country code starting with 78.en_*
locales not covered by the above may be assigned here, i.e.en_BZ
(Belize),en_JM
(Jamaica),en_PH
(Philippines),en_TT
(Trinidad and Tobago).locales.conf
and matchinges_*
are BO=Bolivia, BZ=Belize, CR=Costa Rica, DO=Dominican Republic, GT=Guatemala, HN=Honduras, NI=Nicaragua, PA=Panama, PE=Peru, PR=Puerto Rico, PY=Paraguay, SV=El Salvador, and UY=Uruguay.The remaining country codes used in
locales.conf
may be grouped intocountry.txt
.eebc4f2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added more country codes now.