Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
global out of bounds reads in file_stat() / check_dir() #11
This input file will cause out of bounds reads in fsck.fat:
This can be seen with address sanitizer. Now the situation seems a bit tricky, because different combinations of compilers (gcc or clang) and cflags will show different bugs.
This is with CC set to clang (3.7) and CFLAGS="-fsanitize=address -O3":
This is with CC set to gcc (5.2.0) and CFLAGS="-fsanitize=address -O3" (with older gcc 4.9 bug doesn't show up):
This is with clang (3.7) and CFLAGS="-fsanitize=address -g -O3":
So it seems depending on optimizations different bugs are triggered.
Looks like the same issue everytime actually – it accesses
Haven't looked yet where to put the proper fix (as in, should the zero month field be prevented earlier or just handled here).