Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limited User can't create New Content Types #15285

Closed
DeanGonzalez opened this issue Sep 13, 2018 · 11 comments

Comments

@DeanGonzalez
Copy link

commented Sep 13, 2018

Tested on latest 5.0.1 release on multiple servers, including demo.

To recreate bug:

  1. Create a new blank site
  2. Create a new role and give it full permissions over that site

screen shot 2018-09-13 at 5 32 20 pm

  1. give the role access to the Content Types tool
  2. create a new user, assign the user the role, and try to create a new content type, which exposed the bug

You must create a new site... the case will work if you give the permissions to the starter demo site.

video: https://www.screencast.com/t/hEIh25pwIwBB

@DeanGonzalez DeanGonzalez added this to the Rex Current milestone Sep 13, 2018

@bryanboza bryanboza added this to REX in QA Sep 14, 2018

@bryanboza bryanboza modified the milestone: Rex Current Sep 14, 2018

@bryanboza bryanboza removed this from REX in QA Sep 14, 2018

@DeanGonzalez

This comment has been minimized.

Copy link
Author

commented Sep 17, 2018

We need to make sure a unit test for this to make sure limited users can create Content Types on non-starter hosts if given the right permissions.

@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2018

Both issues have been fixed and this is working as it should now.

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2018

Tested in the last master and I still having the same problems here, please check this again

@bryanboza bryanboza moved this from REX to In Review in QA Oct 16, 2018

@dsilvam dsilvam modified the milestones: 10162018_REX, Rex Current Oct 29, 2018

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2018

Seems the problem is because we are not updating the site selector when you login as.

@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented Nov 7, 2018

Still waiting to this ticket #15304

erickgonzalez added a commit that referenced this issue Dec 4, 2018

@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2018

PR: #15645

erickgonzalez added a commit that referenced this issue Dec 4, 2018

dsilvam added a commit that referenced this issue Dec 4, 2018

#15285 increase permissions level to create content types (#15645)
* #15285 increase permissions level to create content types

* #15285 integrationTest

dsilvam added a commit that referenced this issue Dec 5, 2018

Fix test save content type limited user (#15657)
* #15285 increase permissions level to create content types

* #15285 integrationTest

* #15285 use folder inode instead of identifier
@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2018

Ok after the last changes now we are validating the same permissions to create and edit content types, but if a limited user has permissions to see an existing content type, and you try to add a field, we are showing the error and the field isn't added to the content type, but we show the field in the list, I think this is cache, but we need to refresh the list of fields and remove it.
SC: https://screencast.com/t/09RsNrKXXhvK

@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented Dec 13, 2018

After discussing with @fmontes is a UI issue, so a new issue has been created #15707

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Jan 7, 2019

Fixed, tested after the fix #15707 and now it is working as expected

@wezell wezell closed this Jan 8, 2019

@bryanboza bryanboza moved this from In Review to Done in QA Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.