Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP fails when content that uses $text.get calls a variable in new unpushed language #15359

Closed
wezell opened this issue Oct 1, 2018 · 11 comments

Comments

@wezell
Copy link
Contributor

commented Oct 1, 2018

  1. Add a new language
  2. Add a content based langauge variable in both english and your new language
  3. Add that variable to a piece of content e.g. add $text.get("test")on the "About Us" content
  4. Add the "about us" content to a bundle. Download it for publishing.
  5. upload the bundle for publishing into a new server. Fails.

@wezell wezell added this to the Cody Current milestone Oct 1, 2018

@wezell

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2018

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Oct 1, 2018

Tested locally and it works with the old language variables, the problem is when you use the lang variables as content.

@wezell

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2018

Let's find out if this line of code works:
643ef8d#diff-8cb2c67604652eb7f3612ec73e53c557R650

We also need to complete the integration tests on the factory methods.

@fabrizzio-dotCMS fabrizzio-dotCMS self-assigned this Oct 9, 2018

@wezell

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

We need to remove the auto_increment / identity nature of the language_id field - if it is not too hard.

@wezell

This comment has been minimized.

Copy link
Contributor Author

commented Oct 16, 2018

ee commit dotcms/enterprise-2.x#6db100 should be part of a 5.0.3 build

fabrizzio-dotCMS added a commit that referenced this issue Oct 20, 2018

fabrizzio-dotCMS added a commit that referenced this issue Oct 22, 2018

fabrizzio-dotCMS added a commit that referenced this issue Oct 31, 2018

fabrizzio-dotCMS added a commit that referenced this issue Oct 31, 2018

fabrizzio-dotCMS added a commit that referenced this issue Oct 31, 2018

fabrizzio-dotCMS added a commit that referenced this issue Nov 1, 2018

fabrizzio-dotCMS added a commit that referenced this issue Nov 1, 2018

jgambarios added a commit that referenced this issue Nov 2, 2018

Issue 15359 pp language fails 2 (#15467)
* #15359 save point

* #15359 Adding a map to store language conflits resolutions

* #15359  making an invalidate lang method public + fix on the switch lang action

* #15359 reverting changes no longer needed

* #15359 reverting change in LanguageCache

* #15359 removing unnecessary code

* #15359 Adding javadoc
@jgambarios

This comment has been minimized.

Copy link
Contributor

commented Nov 2, 2018

jgambarios added a commit that referenced this issue Nov 2, 2018

Issue 15359 pp language fails 2 (#15467)
* #15359 save point

* #15359 Adding a map to store language conflits resolutions

* #15359  making an invalidate lang method public + fix on the switch lang action

* #15359 reverting changes no longer needed

* #15359 reverting change in LanguageCache

* #15359 removing unnecessary code

* #15359 Adding javadoc

(cherry picked from commit bff838b)

@bryanboza bryanboza added this to CODY in QA Nov 5, 2018

@jgambarios

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2018

NOTE: Reverted 5.0.3 changes, this issue will be a 5.1 only issue

fabrizzio-dotCMS added a commit that referenced this issue Nov 9, 2018

fabrizzio-dotCMS added a commit that referenced this issue Nov 13, 2018

fabrizzio-dotCMS added a commit that referenced this issue Nov 20, 2018

fabrizzio-dotCMS added a commit that referenced this issue Nov 21, 2018

fabrizzio-dotCMS added a commit that referenced this issue Nov 21, 2018

@jgambarios

This comment has been minimized.

Copy link
Contributor

commented Nov 21, 2018

jgambarios added a commit that referenced this issue Nov 21, 2018

Issue 15359 solve lang conflicts (#15541)
* #15359 remove auto-increment from language table + upgrade task.

* #15359 adding an upgrade task integration test

* #15359 fixing ImportExportUtil when removing non-existing language sequence.

* #15359 improve unit-test  error message

* #15359 drop sequence only if it exists check added

* #15359 Fix drop sequence fro Oracle

* #15359 rename constant

* #15359  check idenity exists msSQL

* #15359 SQL Syntax err fix - Oracle

* #15359 SQL Syntax err fix - Oracle

* #15359 -  changes per feedback

* #15359 renaming Task due to merge conflicts

* #15359 - Change to use a mutabel list impl required by the previous code

@bryanboza bryanboza added this to CODY in QA Jan 10, 2019

@wezell wezell closed this Jan 22, 2019

@wezell wezell reopened this Jan 22, 2019

@jgambarios jgambarios modified the milestones: Cody Current, Cody Backlog Jan 22, 2019

@wezell wezell closed this Jan 29, 2019

@wezell wezell reopened this Jan 29, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

Fixed, tested after the last changes and now I'm unable to reproduce the error. Tested on master // Oracle // FF

@bryanboza bryanboza moved this from CODY to Done in QA Feb 1, 2019

@wezell wezell closed this Feb 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.