Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forced table locks from reindex process #15421

Closed
wezell opened this issue Oct 12, 2018 · 3 comments

Comments

Projects
4 participants
@wezell
Copy link
Contributor

commented Oct 12, 2018

When we reindex we force a table lock on the dist_reindex_journal (and in mysql some other tables). We need to remove this locking logic and come up with a way to insure that a cluster fires a renidex once and then performs the cutover switch once.

With our current pattern of saving content using the dist_reindex_journal for all deferred content, basically the system will stop allowing content saves while a reindex is being setup or switched.

I'd like to see the lock and unlock clusters completely removed from the ReindexThread and we engineer another way forward.

DB locked up:

https://gist.github.com/wezell/ac22bcb1903abb2a9a321c6005ef3461

@nollymar

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

Fixed on #16277

@dsilvam

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Passed Internal QA: Able to reindex properly with client's dataset

@bryanboza bryanboza added this to REX in QA Apr 23, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Fixed, tested reindexing multiple times to make sure everything works as expected and everything works normally

@bryanboza bryanboza moved this from REX to Done in QA Apr 23, 2019

@dsilvam dsilvam closed this Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.