Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving Content fails/freezes with custom list of languages #15624

Closed
jinta opened this issue Nov 29, 2018 · 3 comments

Comments

Projects
4 participants
@jinta
Copy link
Contributor

commented Nov 29, 2018

Expected Behavior

If I'm overriding the list of supported languages to just a few instead of displaying all of them then creating or updating a contentlet should save correctly without crashing/freezing.

Current Behavior

When trying to save any change to a contentlet then the "Saving changes.." dialogue never seems to finish but closing that dialogue would let the changes finish processing. This doesn't happen when the list of languages is the full/unrestricted list.

Possible Solution

The fix would be to update the edit_contentlet_js_inc.jsp file in the saveContentCallback function, specifically the if(entry) bit on line 551 (dotCMS version 5.0.3).
What happens is that it only checks if the entry is undefined but doesn't check if the entry is empty, which is what's causing the problem.
So update that line to also check for empty entry, i.e.:

if(entry != undefined && entry.length > 0)

Known Workarounds

I have to close the popup to let it process the save.

Your Environment

  • dotCMS version used: 5.0.3
  • Browser Name and version: Chrome 70.0.3538.110 (Official Build) (64-bit)
@jgambarios

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2018

PR: #15629

@jinta

This comment has been minimized.

Copy link
Contributor Author

commented Nov 30, 2018

The commit should have fixed the unique issue.

@jinta jinta closed this Nov 30, 2018

@bryanboza bryanboza added this to CODY in QA Nov 30, 2018

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2018

Fixed

@bryanboza bryanboza moved this from CODY to Done in QA Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.