Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove servername and port from portal url generation #15833

Closed
wezell opened this issue Jan 14, 2019 · 3 comments

Comments

Projects
4 participants
@wezell
Copy link
Contributor

commented Jan 14, 2019

When the dotCMS generates a portal URL, it tries to figure out and include the servername, scheme and port.

When running behind a proxy, like when in our docker stack, if you try to run the stack on a non-standard port where dotCMS thinks it is running on one port rather than on another, it gets the generated url wrong. In fact, dotCMS doesn't and can't know what port it is answering on in our docker stack without a plugin and that should not be a requirement.

With the change, it goes from this:

With Host

https://gist.github.com/wezell/a21419f72a0fc34779fa8351ecc736bd

Without Host

https://gist.github.com/wezell/db7d56b023a26a14b09fc77770f32dc4

wezell added a commit that referenced this issue Jan 14, 2019

@wezell

This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

Testing - this might affect the "assigned to" workflow email. If so, we need to give instructions on how to change it.

@wezell wezell added this to the Cody Current milestone Jan 14, 2019

@jgambarios

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2019

PR: #15834

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

Fixed, tested on master // Oracle // FF

@bryanboza bryanboza moved this from REX to Done in QA Feb 5, 2019

@wezell wezell closed this Feb 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.