Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page API json method missing properties #15928

Closed
wezell opened this issue Jan 31, 2019 · 2 comments

Comments

Projects
3 participants
@wezell
Copy link
Contributor

commented Jan 31, 2019

The page API /render/ method contains properties (e.g. viewAs) that are not included in the page API /json/ method. Edit Mode Anywhere means that these methods need to return the same properties, with the /render/ method only adding the rendered properties.

json

screen shot 2019-01-30 at 7 40 07 pm

render

screen shot 2019-01-30 at 7 39 51 pm

wezell added a commit that referenced this issue Jan 31, 2019

wezell added a commit that referenced this issue Jan 31, 2019

wezell added a commit that referenced this issue Feb 1, 2019

@jgambarios

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

PR: #15950

jgambarios added a commit that referenced this issue Feb 1, 2019

Issue 15928 add props to page json (#15950)
* #15928 added viewAs property and unified the classes a bit

* #15928 cleanup

* #15928 return the right object duh

* #15928 unifying render/json page response, respecting langauge

* #15928 reverting change to ESContentlet which will be changed in another commit

wezell added a commit that referenced this issue Feb 1, 2019

wezell added a commit that referenced this issue Feb 1, 2019

wezell added a commit that referenced this issue Feb 1, 2019

@bryanboza bryanboza added this to REX in QA Feb 4, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Feb 7, 2019

Fixed, tested on master // Oracle // FF

@bryanboza bryanboza moved this from REX to Done in QA Feb 7, 2019

@wezell wezell closed this Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.