Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit mode navigation problems #16221

Closed
bryanboza opened this issue Mar 13, 2019 · 5 comments

Comments

@bryanboza
Copy link
Contributor

commented Mar 13, 2019

We have some problems navigating through edit mode. After you change multiple times between edit // preview // live mode we have a JS error and we are unable to navigate.

Expected Behavior

We need be able to navigate on these tabs without problems

Current Behavior

We have a JS error and we are unable to see the live mode

SC: https://screencast.com/t/8u39U0DOYC9n

Steps to Reproduce (for bugs)

  1. Create a new page
  2. Add a piece of content
  3. Go to live mode
  4. Go back to edit and add another piece of content
  5. Change directly to the live tab again
  6. Repeat the steps 2-5 once again

Make sure you can continue navigating through tabs

Your Environment

Tested on master // Postgres // FF

@bryanboza

This comment has been minimized.

Copy link
Contributor Author

commented Mar 15, 2019

If you add an unpublished piece of content to some page, this is breaking the edit mode, you are able to see the piece of content in the live tab and this is causing an error that we show in the log file every time you go to this tab.
Log: https://gist.github.com/bryanboza/2e86b980e4d92c56acd29f34403e73f2
SC: https://screencast.com/t/KqW0PEZK

Tested on the release distro // H2 // FF

@bryanboza bryanboza moved this from FOX to In Review in QA Mar 15, 2019

@fmontes fmontes removed this from In Review in QA Mar 21, 2019

@fmontes

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

@bryanboza this is not happening to us in core/master, maybe you didn't have the change when you tested the first time? can you give it another go?

@bryanboza bryanboza added this to FOX in QA Mar 21, 2019

@fmontes fmontes modified the milestones: 5.1_03182019_FOX, Fox Current Mar 22, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

Unable to reproduce on master... I found the problem with release-5.1.0

@oarrietadotcms

This comment has been minimized.

Copy link
Contributor

commented Mar 25, 2019

In order to fix the problem reported by @bryanboza in this comment: #16221 (comment)

We needed to implement this commit: 6bbae99

I think that commit was linked to the wrong Github issue by mistake.

@jgambarios jgambarios removed this from Done in QA Mar 26, 2019

@bryanboza bryanboza added this to FOX in QA Mar 26, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Fixed, tested on release-5.1.1 branch and now it works as expected

@bryanboza bryanboza moved this from FOX to Done in QA Mar 26, 2019

@fmontes fmontes closed this Apr 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.