Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon selector in edit toolgroup breaks on invalid values #16246

Closed
fmontes opened this issue Mar 18, 2019 · 4 comments

Comments

@fmontes
Copy link
Member

commented Mar 18, 2019

slack-imgs.png

Acceptance Criteria

  1. Make sure that field doesn't break when invalid value is set, don't just don't show icon.
  2. Work in all the supported browsers (don't forget IE11 and iPad)
  3. Multilanguage
  4. Unit test
@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

also we are unable to see the previous ones on the left menu
https://screencast.com/t/Zinhdbcm

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

After discussing that fix we need to take in consideration those cases

  • Should we set a default icon or remove it totally after upgrade from previous versions?
  • We need to validate the entered value is a valid one, in order to avoid breaking the left menu

@bryanboza bryanboza moved this from FOX to In Review in QA Apr 4, 2019

@fmontes

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2019

We did constrain the icon space so if no icon show it will always be the same size, also applying a css property to the content of the icon is always constrain to 18x18px.

Still users can add (or upgrade) whatever string will no break the nav but in some cases like "Types & Tags" or stuff like that will not show anything, so fallback is blank.

  1. Should we set a default icon or remove it totally after upgrade from previous versions?

    • We can't there is nothing we can take to differentiate if the string is valid or not unless we do a way more advance icon selector.
  2. We need to validate the entered value is a valid one, in order to avoid breaking the left menu

    • In order to do this we have to hit some endpoint where we can look up if the string exist in material design and keep that endpoint upgrade it everytime there is a new icon in the library. Is not priority at this point.

@fmontes fmontes self-assigned this Apr 18, 2019

fmontes added a commit to dotCMS/core-web that referenced this issue Apr 18, 2019

fmontes added a commit to dotCMS/core-web that referenced this issue Apr 18, 2019

fmontes added a commit to dotCMS/core-web that referenced this issue Apr 18, 2019

fmontes added a commit to dotCMS/core-web that referenced this issue Apr 23, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Fixex for now, now we support both libraries and also are able to edit without problems

@bryanboza bryanboza moved this from In Review to Done in QA Apr 24, 2019

fmontes added a commit that referenced this issue May 4, 2019

fmontes added a commit that referenced this issue May 4, 2019

@fmontes fmontes removed the WF : Needs Work label May 4, 2019

@wezell wezell closed this May 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.