Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use container path in page render #16263

Closed
jgambarios opened this issue Mar 20, 2019 · 5 comments

Comments

@jgambarios
Copy link
Contributor

commented Mar 20, 2019

We have found errors in the page render where in some places we are using the container path to compare with the container id, the render code in the back end and front end can use the id without problem even if the container is a Container as files, the only thing we need to avoid is to save ids in the Template table where indeed we need to use the path.

@jgambarios jgambarios added this to the Cody Current milestone Mar 20, 2019

@jgambarios

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

Related to #16264

jdotcms added a commit that referenced this issue Mar 29, 2019

#16263 after the change the file asset container now use just the par…
…t on the data-dot-identifier and are not sent twice in the container node in the page rendered

@jdotcms jdotcms self-assigned this Mar 29, 2019

jdotcms added a commit that referenced this issue Apr 3, 2019

jdotcms added a commit that referenced this issue Apr 4, 2019

jdotcms added a commit that referenced this issue Apr 8, 2019

#16263 now using the parent path instead of the path itself for the o…
…ntainer uuid when it is file asset container

jgambarios added a commit that referenced this issue Apr 9, 2019

Issue 16263 changes tosupport containerpath onpagerender (#16317)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16263 after the change the file asset container now use just the part on the data-dot-identifier and are not sent twice in the container node in the page rendered

* #16263 the container UUID now has a path instead of id when it is a file asset container

* #16263 dealing with path instead of id when the container is file asset

* #16263 now using the parent path instead of the path itself for the ontainer uuid when it is file asset container
@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

  • After those changes, we are unable to add contents to the pages

  • Also, we need to add some UI tests in to avoid this kind of basic issues

@bryanboza bryanboza added this to In Review in QA Apr 9, 2019

@jgambarios

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

We need also to modify the end point /api/v1/containers/{id}/content/{inode} to support container paths, right now a request like this:
/api/v1/containers//application/containers/large-column//content/27108d63-969e-4086-a405-86777be16230 would break the edit mode.

An option is to create a v2 of the end point and sent the container as a query param supporting ids and paths:
/api/v2/content/27108d63-969e-4086-a405-86777be16230?container=/application/containers/large-column/
or
/api/v2/content/27108d63-969e-4086-a405-86777be16230?container=123456789

jdotcms added a commit that referenced this issue Apr 9, 2019

jdotcms added a commit that referenced this issue Apr 10, 2019

@wezell wezell changed the title Stop using container path in page render Use container path in page render Apr 11, 2019

@jgambarios

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

PR: #16392

jgambarios added a commit that referenced this issue Apr 12, 2019

Issue 16263 changes tosupport containerpath onpagerender (#16392)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16263 after the change the file asset container now use just the part on the data-dot-identifier and are not sent twice in the container node in the page rendered

* #16263 the container UUID now has a path instead of id when it is a file asset container

* #16263 dealing with path instead of id when the container is file asset

* #16263 now using the parent path instead of the path itself for the ontainer uuid when it is file asset container

* #16263 adding support for container/content to get the html for a container file asset

* #16263 fix to use the current host when there is not a host in the container id as a path
@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

Fixed, tested on master // postgres // FF

@bryanboza bryanboza moved this from In Review to Done in QA Apr 16, 2019

@wezell wezell closed this Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.