Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShortyCache does not invalidate #16310

Closed
wezell opened this issue Mar 29, 2019 · 7 comments

Comments

@wezell
Copy link
Contributor

commented Mar 29, 2019

We never invalidate the shortycache when an identifier or content is checked in. This means, for example, if you push publish a content that references a shorty driven image or asset and do not push that asset as well - e.g. the image on the about us page, it will 404. If you then push that image, the 404 image will never recover until you flush cache. We need to invalidate the shorty cache on content and identifier checkin.

wezell added a commit that referenced this issue Mar 29, 2019

wezell added a commit that referenced this issue Mar 29, 2019

@wezell

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2019

dupes #14546

@wezell wezell added this to the Cody Current milestone Apr 2, 2019

jdotcms added a commit that referenced this issue Apr 10, 2019

jdotcms added a commit that referenced this issue Apr 11, 2019

jgambarios added a commit that referenced this issue Apr 12, 2019

Issue 16359 shorty invalidation2 (#16379)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16310 invalidate shortyId on identifier and content

* #16310 adding to cache

* #16359 adding unit test and changes to invalidate the shorties
@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

jgambarios added a commit that referenced this issue Apr 12, 2019

Issue 16359 shorty invalidation2 (#16387)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16310 invalidate shortyId on identifier and content

* #16310 adding to cache

* #16359 adding unit test and changes to invalidate the shorties

* #16359 fixing an issue when the id is null
@jgambarios

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

PR: #16387

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

Fixed, I made a sanity test to make sure everything continues working as expected

@bryanboza bryanboza moved this from CODY to Done in QA Apr 15, 2019

@wezell wezell closed this Apr 15, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

After these changes we are unable to upload file assets, we have an error in the JSP file when you try it
Here the log: https://gist.github.com/bryanboza/4330b1a7e2ec80354c48266765a62876
error1

@bryanboza bryanboza reopened this Apr 16, 2019

@bryanboza bryanboza moved this from Done to CODY in QA Apr 17, 2019

@bryanboza bryanboza moved this from CODY to In Review in QA Apr 17, 2019

jdotcms added a commit that referenced this issue Apr 17, 2019

jdotcms added a commit that referenced this issue Apr 17, 2019

@jgambarios

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

PR: #16415

jgambarios added a commit that referenced this issue Apr 23, 2019

Issue 16310 fixing issue shortify (#16415)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16310 fixing an issue when the shorty is not valid on the shortify

* #16310 fixes when the length of the shorty passed is less than 10 to about out of bounds
@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

Fixed, tested on master // Oracle // FF

@bryanboza bryanboza moved this from In Review to Done in QA Apr 24, 2019

@wezell wezell closed this Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.